Bug 42150 - [Qt] CSS border style not cleared for SVG object
Summary: [Qt] CSS border style not cleared for SVG object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P3 Normal
Assignee: QtWebKit Unassigned
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-07-13 01:11 PDT by mirko
Modified: 2010-07-14 19:56 PDT (History)
2 users (show)

See Also:

Attachments
Proposed patch. (1.13 KB, patch)
2010-07-13 01:19 PDT, mirko 		hausmann: review+
hausmann: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description mirko 2010-07-13 01:11:47 PDT 
The same bug as stated by report https://bugs.webkit.org/show_bug.cgi?id=25738
is present within the Qt binding of WebKit.
Comment 1 mirko 2010-07-13 01:19:33 PDT 
Created attachment 61343 [details]
Proposed patch.
Comment 2 Andreas Kling 2010-07-13 03:58:10 PDT 
Comment on attachment 61343 [details]
Proposed patch.

While the change looks fairly reasonable, I cannot actually reproduce the problem with QtWebKit trunk.
What versions of Qt and QtWebKit are you using?
Comment 3 Kenneth Rohde Christiansen 2010-07-13 04:03:50 PDT 
Wrong coding style, though. Should not use braces.
Comment 4 Simon Hausmann 2010-07-14 01:44:55 PDT 
Comment on attachment 61343 [details]
Proposed patch.

Yeah, patch looks good to me. It's a safe thing to do, and the original patch for Skia is doing the same. 

Would be nice to join the layout test coverage for this.

I'm going to say r+ but cq- because it needs the coding style fix before landing. So if someone wants to land it, go ahead :). Otherwise Mirko just attach a new patch and we'll run it through the commit queue.
Comment 5 Andreas Kling 2010-07-14 19:56:25 PDT 
Committed r63394: <http://trac.webkit.org/changeset/63394>