Bug 25738 - Skia: CSS border style not cleared for SVG object
Summary: Skia: CSS border style not cleared for SVG object
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-05-12 15:37 PDT by Roland Steiner
Modified: 2009-05-12 21:47 PDT (History)
0 users

See Also:


Attachments
Patch: override with SolidStroke if no dash set (1.84 KB, patch)
2009-05-12 17:43 PDT, Roland Steiner
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roland Steiner 2009-05-12 15:37:42 PDT
[First reported here: http://code.google.com/p/chromium/issues/detail?id=9580]

On Chrome (Skia), the SVG triangle rendered with the following HTML has a dotted outline.

EXPECTED: The triangle should have a solid outline.

<html xmlns="http://www.w3.org/1999/xhtml">
<head></head>
<body>
<div style="border: 4px dotted black; height:100px; width: 100px"></div>
<svg width="300" height="300" version="1.1" xmlns="http://www.w3.org/2000/svg">
<polyline points="100,100 100,200 200,200 100,100" style="stroke:red;stroke-width:5;stroke-dasharray:none"/>
</svg>
</body>
</html>
Comment 1 Roland Steiner 2009-05-12 17:43:06 PDT
Created attachment 30256 [details]
Patch: override with SolidStroke if no dash set

I haven't (yet) added a new layout test for this patch due to the additional complications with different rendering styles for dotted lines on all platforms (cf. https://bugs.webkit.org/show_bug.cgi?id=25737)
Comment 2 Eric Seidel (no email) 2009-05-12 18:26:24 PDT
Comment on attachment 30256 [details]
Patch: override with SolidStroke if no dash set

I'm a good choice to review this.  But you don't actually need to specify a reviewer for WebKit reviews.  In fact, they'll often happen quicker if you don't.

This change needs a test case as part of the patch.  Otherwise, this looks fine.  I'll add the test you provided when I land this (even though the test already passes for WebKit Mac).
Comment 3 Eric Seidel (no email) 2009-05-12 21:47:12 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	LayoutTests/ChangeLog
	A	LayoutTests/platform/mac/svg/custom/no-inherited-dashed-stroke-expected.checksum
	A	LayoutTests/platform/mac/svg/custom/no-inherited-dashed-stroke-expected.png
	A	LayoutTests/platform/mac/svg/custom/no-inherited-dashed-stroke-expected.txt
	A	LayoutTests/svg/custom/no-inherited-dashed-stroke.xhtml
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/skia/GraphicsContextSkia.cpp
Committed r43608