Bug 42096 - HTMLTreeBuilder needs to support mixing SVG and MathML content
Summary: HTMLTreeBuilder needs to support mixing SVG and MathML content
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-12 11:18 PDT by Eric Seidel (no email)
Modified: 2010-07-12 14:13 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.68 KB, patch)
2010-07-12 11:32 PDT, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-12 11:18:55 PDT
HTMLTreeBuilder needs to support mixing SVG and MathML content
Comment 1 Eric Seidel (no email) 2010-07-12 11:32:15 PDT
Created attachment 61249 [details]
Patch
Comment 2 Adam Barth 2010-07-12 13:31:48 PDT
Comment on attachment 61249 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:1161
 +          return (token.name() != MathMLNames::mglyphTag
Why ( .. ) ?  We don't need those in C++.

WebCore/html/HTMLTreeBuilder.cpp:1489
 +          // FIXME: We're missing a bunch of if branches here.
I'd remove this comment.
Comment 3 Eric Seidel (no email) 2010-07-12 13:32:49 PDT
(In reply to comment #2)
> (From update of attachment 61249 [details])
> WebCore/html/HTMLTreeBuilder.cpp:1161
>  +          return (token.name() != MathMLNames::mglyphTag
> Why ( .. ) ?  We don't need those in C++.

Will remove.

> WebCore/html/HTMLTreeBuilder.cpp:1489
>  +          // FIXME: We're missing a bunch of if branches here.
> I'd remove this comment.

That goes away two patches later. :)
Comment 4 Eric Seidel (no email) 2010-07-12 14:13:31 PDT
Committed r63116: <http://trac.webkit.org/changeset/63116>