Bug 41991 - HTML5 tree builder should pass some LayoutTests
Summary: HTML5 tree builder should pass some LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-09 14:40 PDT by Adam Barth
Modified: 2010-07-09 20:48 PDT (History)
3 users (show)

See Also:

Attachments
Patch (2.60 KB, patch)
2010-07-09 14:43 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (2.91 KB, patch)
2010-07-09 14:53 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-09 14:40:35 PDT 
HTML5 tree builder should pass some LayoutTests
Comment 1 Adam Barth 2010-07-09 14:43:02 PDT 
Created attachment 61101 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-09 14:46:56 PDT 
Comment on attachment 61101 [details]
Patch

WebCore/html/HTMLConstructionSite.cpp:103
 +      RefPtr<Node> child = prpChild;
This causes us to end up taking an extra reference.  We should steal a raw pointer for our ASSERTs.  parserAddChild can never fail.

Why do we need to be attaching text nodes?  Is something wrong in the lazy attach codepath?  Does DRT need to be calling some layout method that it's not?
Comment 3 Eric Seidel (no email) 2010-07-09 14:48:37 PDT 
Comment on attachment 61101 [details]
Patch

You need to at least add a FIXME about the extra ref problem.  But it  seems silly/lazy to not just fix it now. :p

CC'd James R. about understanding the Text node lazy-attach failure problem.
Comment 4 Adam Barth 2010-07-09 14:53:04 PDT 
Created attachment 61105 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-07-09 20:48:07 PDT 
Comment on attachment 61105 [details]
Patch for landing

Clearing flags on attachment: 61105

Committed r63037: <http://trac.webkit.org/changeset/63037>
Comment 6 WebKit Commit Bot 2010-07-09 20:48:12 PDT 
All reviewed patches have been landed.  Closing bug.