WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
41943
Add basic "in foreign content" support to the TreeBuilder
https://bugs.webkit.org/show_bug.cgi?id=41943
Summary
Add basic "in foreign content" support to the TreeBuilder
Eric Seidel (no email)
Reported
2010-07-09 02:08:59 PDT
Add basic "in foreign content" support to the TreeBuilder
Attachments
Patch
(39.88 KB, patch)
2010-07-09 02:14 PDT
,
Eric Seidel (no email)
abarth
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1
2010-07-09 02:14:09 PDT
Created
attachment 61020
[details]
Patch
Adam Barth
Comment 2
2010-07-09 02:36:36 PDT
Comment on
attachment 61020
[details]
Patch Cool! WebCore/html/HTMLElementStack.cpp:336 + bool HTMLElementStack::isOnlyHTMLElementsInScope() const hasOnlyHTMLElementsInScope ? WebCore/html/HTMLTreeBuilder.cpp:1395 + else This doesn't work right if MATHML is turned on and SVG is off. WebCore/html/HTMLTreeBuilder.cpp:1402 + m_tree.insertForeignElement(token, m_tree.currentElement()->namespaceURI()); Why do we re-read this instead of using currentNamespace? WebCore/html/HTMLTreeBuilder.cpp:2194 + if (token.name() == SVGNames::scriptTag && m_tree.currentElement()->hasTagName(SVGNames::scriptTag)) { Missing #ifdef SVG WebCore/html/HTMLTreeBuilder.cpp:2236 + } insert blank line
Eric Seidel (no email)
Comment 3
2010-07-09 03:18:00 PDT
Oops, this got landed with another change as part of
http://trac.webkit.org/changeset/62926
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug