Bug 41943 - Add basic "in foreign content" support to the TreeBuilder
Summary: Add basic "in foreign content" support to the TreeBuilder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-09 02:08 PDT by Eric Seidel (no email)
Modified: 2010-07-09 03:18 PDT (History)
1 user (show)

See Also:


Attachments
Patch (39.88 KB, patch)
2010-07-09 02:14 PDT, Eric Seidel (no email)
abarth: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-09 02:08:59 PDT
Add basic "in foreign content" support to the TreeBuilder
Comment 1 Eric Seidel (no email) 2010-07-09 02:14:09 PDT
Created attachment 61020 [details]
Patch
Comment 2 Adam Barth 2010-07-09 02:36:36 PDT
Comment on attachment 61020 [details]
Patch

Cool!

WebCore/html/HTMLElementStack.cpp:336
 +  bool HTMLElementStack::isOnlyHTMLElementsInScope() const
hasOnlyHTMLElementsInScope ?

WebCore/html/HTMLTreeBuilder.cpp:1395
 +          else
This doesn't work right if MATHML is turned on and SVG is off.

WebCore/html/HTMLTreeBuilder.cpp:1402
 +          m_tree.insertForeignElement(token, m_tree.currentElement()->namespaceURI());
Why do we re-read this instead of using currentNamespace?

WebCore/html/HTMLTreeBuilder.cpp:2194
 +          if (token.name() == SVGNames::scriptTag && m_tree.currentElement()->hasTagName(SVGNames::scriptTag)) {
Missing #ifdef SVG

WebCore/html/HTMLTreeBuilder.cpp:2236
 +      }
insert blank line
Comment 3 Eric Seidel (no email) 2010-07-09 03:18:00 PDT
Oops, this got landed with another change as part of http://trac.webkit.org/changeset/62926.