Bug 41932 - [Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Summary: [Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 38570
  Show dependency treegraph
 
Reported: 2010-07-08 23:01 PDT by Kent Tamura
Modified: 2010-07-15 23:25 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.47 KB, patch)
2010-07-09 01:58 PDT, Kent Tamura
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-07-08 23:01:18 PDT
[Chromium] Update ThemeChromiumMac.mm for the recent changes of ThemeMac.mm
Comment 1 Kent Tamura 2010-07-09 01:58:58 PDT
Created attachment 61017 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-15 21:22:10 PDT
Comment on attachment 61017 [details]
Patch

I don't think there is much I can review here.  Only really rubber-stamp.  Assuming it works for Chromium, rs=me.
Comment 3 Joseph Pecoraro 2010-07-15 21:32:16 PDT
Comment on attachment 61017 [details]
Patch

> +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm
> +        case OuterSpinButtonPart: {
> +            static const int stepperMargin[4] = { 0, 0, 0, 0};

Probably a negligible style issue. Missing a space at the end? "0 };"
Comment 4 Kent Tamura 2010-07-15 21:55:28 PDT
Committed r63514: <http://trac.webkit.org/changeset/63514>
Comment 5 Kent Tamura 2010-07-15 22:19:04 PDT
(In reply to comment #3)
> (From update of attachment 61017 [details])
> > +++ b/WebCore/platform/chromium/ThemeChromiumMac.mm
> > +        case OuterSpinButtonPart: {
> > +            static const int stepperMargin[4] = { 0, 0, 0, 0};
> 
> Probably a negligible style issue. Missing a space at the end? "0 };"

Thank you for pointing it out.
I have fixed it and the same one in ThemeMac.mm by http://trac.webkit.org/changeset/63518