Bug 41895 - [MathML] Implement mathcolor and mathbackground attributes
Summary: [MathML] Implement mathcolor and mathbackground attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: MathML (show other bugs)
Version: 528+ (Nightly build)
Hardware: Macintosh Intel OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on: 41889
Blocks: 3251
  Show dependency treegraph
 
Reported: 2010-07-08 13:20 PDT by François Sausset
Modified: 2010-07-09 11:23 PDT (History)
1 user (show)

See Also:


Attachments
Patch (31.37 KB, patch)
2010-07-08 14:16 PDT, François Sausset
no flags Details | Formatted Diff | Diff
Revised Patch (31.36 KB, patch)
2010-07-08 14:46 PDT, François Sausset
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description François Sausset 2010-07-08 13:20:05 PDT
Implementation & test case for the mathcolor and mathbackground attributes defined in the MathML 3 w3c Draft:
http://www.w3.org/TR/MathML3/chapter3.html#presm.presatt
Comment 1 François Sausset 2010-07-08 14:16:28 PDT
Created attachment 60957 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-07-08 14:38:13 PDT
Comment on attachment 60957 [details]
Patch

WebCore/mathml/MathMLElement.cpp:4
 +   * Copyright (C) 2010 François Sausset (sausset@gmail.com). All rights reserved.
There seems to be some unicode issues here.

 62     if (attr->name() == MathMLNames::mathcolorAttr) {
 63         addCSSProperty(attr, CSSPropertyColor, attr->value());
 64     } else if (attr->name() == MathMLNames::mathbackgroundAttr) {
 65         addCSSProperty(attr, CSSPropertyBackgroundColor, attr->value());
 66         
 67     } else
 68         StyledElement::parseMappedAttribute(attr);

These one liners should not have braces. There is also a strange newline before the last else.

Apart from this the patch looks fine. Please fix these things before committing.
Comment 3 François Sausset 2010-07-08 14:46:02 PDT
Created attachment 60962 [details]
Revised Patch

Correct the style issues.
Comment 4 Eric Seidel (no email) 2010-07-09 03:16:43 PDT
Comment on attachment 60957 [details]
Patch

Cleared Kenneth Rohde Christiansen's review+ from obsolete attachment 60957 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 5 WebKit Commit Bot 2010-07-09 11:23:13 PDT
Comment on attachment 60962 [details]
Revised Patch

Clearing flags on attachment: 60962

Committed r62968: <http://trac.webkit.org/changeset/62968>
Comment 6 WebKit Commit Bot 2010-07-09 11:23:17 PDT
All reviewed patches have been landed.  Closing bug.