Bug 41889 – MathML - msqrt and mfrac should use the color defined in style() to draw themselves

• Status: RESOLVED
• Resolution: FIXED
• Component: MathML

[François Sausset]

Created attachment 60929 [details]
Test case

See the test case

[François Sausset]

Created attachment 60930 [details]
Patch

[François Sausset]

Created attachment 60935 [details]
Patch

Patch to fix the same problem for mfrac

[François Sausset]

I was not clear previously: the patch fix the problem for both mfrac and msqrt

[Kenneth Rohde Christiansen]

Comment on attachment 60935 [details]
Patch

Why are there two ChangeLog entries for one patch?

[François Sausset]

(In reply to comment #4)
> (From update of attachment 60935 [details])
> Why are there two ChangeLog entries for one patch?

It was a mistake when generating the patch.

[François Sausset]

Created attachment 60964 [details]
Revised patch

[Kenneth Rohde Christiansen]

Comment on attachment 60964 [details]
Revised patch

WebCore/ChangeLog:6
 +          https://bugs.webkit.org/show_bug.cgi?id=41889
I would like your ChangeLog to explain a bit better how you fixed the bug.

Normally it will show me the PNG images while reviewing, but in this bug it just shows me their contents. Are you sure there is nothing wrong with them?

[François Sausset]

Created attachment 61042 [details]
Revised patch

More detailed ChangeLog.

The PNG files seems to be OK: they were generated by the standard method and I can read them normally on my computer.

[WebKit Commit Bot]

Comment on attachment 61042 [details]
Revised patch

Rejecting patch 61042 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 61042, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
ols/Scripts/webkitpy/tool/commands/download.py", line 155, in _process_patch
    self._main_sequence.run_and_handle_errors(tool, options, state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 80, in run_and_handle_errors
    raise e
webkitpy.common.system.executive.ScriptError: Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1

[François Sausset]

Created attachment 61157 [details]
Regenerated patch

Same than previous patch except that the PNG tests have been regenerated as it indeed seems they were problematic.

[WebKit Commit Bot]

Comment on attachment 61157 [details]
Regenerated patch

Clearing flags on attachment: 61157

Committed r63074: <http://trac.webkit.org/changeset/63074>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.