Bug 41839 - [Qt] QScriptEngine should work correctly even after global object changes
Summary: [Qt] QScriptEngine should work correctly even after global object changes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31863
  Show dependency tree / graph
 
Reported: 2010-07-08 01:18 PDT by Jędrzej Nowacki
Modified: 2010-07-14 07:35 PDT (History)
4 users (show)

See Also:

Attachments
Fix v1 (22.74 KB, patch)
2010-07-14 04:42 PDT, Jędrzej Nowacki 		no flags Details | Formatted Diff | Diff
Fix v1.01 (22.73 KB, patch)
2010-07-14 06:45 PDT, Jędrzej Nowacki 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-07-08 01:18:29 PDT 
Some algorithms in the QScriptValue and in the QScriptEngine (like QSV::isError() method) are not prepared for Global Object changes. It would be nice to keep a reference to some of global object's properties in QScriptEnginePrivate, for future use.
Comment 1 Jędrzej Nowacki 2010-07-14 04:42:54 PDT 
Created attachment 61502 [details]
Fix v1
Comment 2 Jędrzej Nowacki 2010-07-14 06:45:38 PDT 
Created attachment 61514 [details]
Fix v1.01

Rebased against trunk
Comment 3 Kenneth Rohde Christiansen 2010-07-14 06:51:51 PDT 
Comment on attachment 61514 [details]
Fix v1.01

Nice that you are concentrating all method that will need C api in the future. r=me
Comment 4 WebKit Commit Bot 2010-07-14 07:35:18 PDT 
Comment on attachment 61514 [details]
Fix v1.01

Clearing flags on attachment: 61514

Committed r63318: <http://trac.webkit.org/changeset/63318>
Comment 5 WebKit Commit Bot 2010-07-14 07:35:22 PDT 
All reviewed patches have been landed.  Closing bug.