Bug 41830 - [EFL] fix cmake build for EWebLauncher
Summary: [EFL] fix cmake build for EWebLauncher
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 20:49 PDT by Joone Hur
Modified: 2010-07-08 22:42 PDT (History)
5 users (show)

See Also:


Attachments
Proposed patch (854 bytes, patch)
2010-07-07 21:21 PDT, Joone Hur
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joone Hur 2010-07-07 20:49:24 PDT
-- Generating done
-- Build files have been written to: /home/joone/git/WebKit/WebKitBuild/Debug_Efl
[  2%] Built target wtf
[  9%] Built target javascriptcore
[  9%] Built target jsc
[100%] Built target webcore
[100%] Built target ewebkit
Linking CXX executable ../Programs/EWebLauncher
libewebkit.so: undefined reference to `soup_message_get_first_party'
libewebkit.so: undefined reference to `soup_message_set_first_party'
libewebkit.so: undefined reference to `soup_session_prepare_for_uri'
libewebkit.so: undefined reference to `soup_cookie_jar_set_accept_policy'
libewebkit.so: undefined reference to `soup_cookie_jar_set_cookie_with_first_party'
collect2: ld returned 1 exit status
make[2]: *** [WebKit/../Programs/EWebLauncher] Error 1
make[1]: *** [WebKit/CMakeFiles/../Programs/EWebLauncher.dir/all] Error 2
make: *** [all] Error 

Building EWebLauncher has a link error.
Comment 1 Joone Hur 2010-07-07 21:21:21 PDT
Created attachment 60833 [details]
Proposed patch

CMakeListsEfl.txt: add ${LIBSOUP24_LDFLAGS} for link flags
Comment 2 Lucas De Marchi 2010-07-07 21:31:41 PDT
(In reply to comment #1)
> Created an attachment (id=60833) [details]
> Proposed patch
> 
> CMakeListsEfl.txt: add ${LIBSOUP24_LDFLAGS} for link flags

This was a recent change to fix cross compile on some environments. I'm CC'ing who did this.
Comment 3 Rafael Antognolli 2010-07-08 08:00:21 PDT
The patch is correct. I didn't notice this because my other patch in bug 41770 also includes this fix. But this one should get in first, then I'll update that one.
Comment 4 Antonio Gomes 2010-07-08 19:05:15 PDT
Comment on attachment 60833 [details]
Proposed patch

Ok.
Comment 5 WebKit Commit Bot 2010-07-08 22:42:45 PDT
Comment on attachment 60833 [details]
Proposed patch

Clearing flags on attachment: 60833

Committed r62895: <http://trac.webkit.org/changeset/62895>
Comment 6 WebKit Commit Bot 2010-07-08 22:42:50 PDT
All reviewed patches have been landed.  Closing bug.