Bug 41770 - [EFL] Add API for dealing with cookies in EFL port.
Summary: [EFL] Add API for dealing with cookies in EFL port.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit EFL (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 08:39 PDT by Rafael Antognolli
Modified: 2010-07-13 13:24 PDT (History)
5 users (show)

See Also:

Attachments
Patch (9.99 KB, patch)
2010-07-07 08:46 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
Patch (11.43 KB, patch)
2010-07-07 08:59 PDT, Rafael Antognolli 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Patch (11.02 KB, patch)
2010-07-13 11:40 PDT, Rafael Antognolli 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rafael Antognolli 2010-07-07 08:39:39 PDT 
[EFL] Add API for dealing with cookies in EFL port.
Comment 1 Rafael Antognolli 2010-07-07 08:46:38 PDT 
Created attachment 60737 [details]
Patch
Comment 2 Rafael Antognolli 2010-07-07 08:59:21 PDT 
Created attachment 60739 [details]
Patch
Comment 3 Antonio Gomes 2010-07-13 11:16:22 PDT 
Comment on attachment 60739 [details]
Patch

Good work!

Note that the gtk guys preferred to just expose the current soup session through webkit_get_default_session(). That way, it delegates any manipulation/management to the application.
Comment 4 Rafael Antognolli 2010-07-13 11:40:55 PDT 
Created attachment 61402 [details]
Patch
Comment 5 WebKit Commit Bot 2010-07-13 11:42:12 PDT 
Comment on attachment 60739 [details]
Patch

Rejecting patch 60739 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Parsed 5 diffs from patch file(s).
patching file WebKit/CMakeListsEfl.txt
Hunk #2 FAILED at 91.
1 out of 2 hunks FAILED -- saving rejects to file WebKit/CMakeListsEfl.txt.rej
patching file WebKit/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/efl/ewk/EWebKit.h
patching file WebKit/efl/ewk/ewk_cookies.cpp
patching file WebKit/efl/ewk/ewk_cookies.h

Full output: http://webkit-commit-queue.appspot.com/results/3528110
Comment 6 Antonio Gomes 2010-07-13 11:45:53 PDT 
Comment on attachment 61402 [details]
Patch

Lets try again with this un-bitrotted new version
Comment 7 WebKit Commit Bot 2010-07-13 13:24:38 PDT 
Comment on attachment 61402 [details]
Patch

Clearing flags on attachment: 61402

Committed r63241: <http://trac.webkit.org/changeset/63241>
Comment 8 WebKit Commit Bot 2010-07-13 13:24:43 PDT 
All reviewed patches have been landed.  Closing bug.