Bug 41805 - Web Inspector: Migrate Storage Panel to InspectorFrontend2
Summary: Web Inspector: Migrate Storage Panel to InspectorFrontend2
Status: RESOLVED DUPLICATE of bug 43482
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-07-07 14:52 PDT by Joseph Pecoraro
Modified: 2010-08-11 09:46 PDT (History)
15 users (show)

See Also:


Attachments
[PATCH] Migrate InspectorApplicationCacheAgent (14.71 KB, patch)
2010-07-07 15:00 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Migrate Application Cache (14.71 KB, patch)
2010-07-07 17:15 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Migrate Cookies (7.06 KB, patch)
2010-07-07 22:48 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Migrate Databases (13.92 KB, patch)
2010-07-07 22:49 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff
[PATCH] Migrate DOM Storage (14.95 KB, patch)
2010-07-07 22:49 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2010-07-07 14:52:02 PDT
Might as well try to add all new interfaces as InspectorFrontend2! This also catches
a few minor idl generator improvements $(FEATURE_DEFINES) for handling compile
time flags in InspectorFrontend2.idl.

I can break this down into separate patches if desired.
Comment 1 Joseph Pecoraro 2010-07-07 15:00:08 PDT
Created attachment 60784 [details]
[PATCH] Migrate InspectorApplicationCacheAgent

Please double check the build changes. I am unfamiliar with many of the
build systems, but I think this was rather straightforward.

I think some should already work:

  GNUmakefile.am               has  $(FEATURE_DEFINES)
  WebCore.pri                  has  $${FEATURE_DEFINES_JAVASCRIPT}}
  cmake/WebKitGenerators.cmake has  ${FEATURE_DEFINES_STR}
Comment 2 Early Warning System Bot 2010-07-07 15:23:21 PDT
Attachment 60784 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3416358
Comment 3 Eric Seidel (no email) 2010-07-07 15:25:58 PDT
Attachment 60784 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3362454
Comment 4 Joseph Pecoraro 2010-07-07 15:46:52 PDT
The bots failed because this is missing a patch that I haven't landed yet. There is a lot of activity on the bots right now, and that patch is in the queue.
Comment 5 WebKit Review Bot 2010-07-07 16:00:47 PDT
Attachment 60784 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3365442
Comment 6 WebKit Review Bot 2010-07-07 16:28:11 PDT
Attachment 60784 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3380454
Comment 7 Joseph Pecoraro 2010-07-07 17:15:12 PDT
Created attachment 60809 [details]
[PATCH] Migrate Application Cache

Landed the required part in r62731. So re-uploading this so they
test with a (hopefully) ToT try-bot.
Comment 8 Joseph Pecoraro 2010-07-07 22:48:56 PDT
Created attachment 60840 [details]
[PATCH] Migrate Cookies
Comment 9 Joseph Pecoraro 2010-07-07 22:49:19 PDT
Created attachment 60841 [details]
[PATCH] Migrate Databases
Comment 10 Joseph Pecoraro 2010-07-07 22:49:40 PDT
Created attachment 60842 [details]
[PATCH] Migrate DOM Storage
Comment 11 Joseph Pecoraro 2010-07-07 22:52:30 PDT
Miscellaneous minor fixes / improvements:
  - numerous style fixes
  - numerous unnecessary headers
  - addDatabase no longer needs a bool return value, no need to check for an exception
  - addDOMStorage no longer needs a bool return value, ditto
  - added a few "const"s
  - fix DatabaseTableView's statusbar icon
Comment 12 Pavel Feldman 2010-07-17 04:40:43 PDT
Ilya, I can stamp these if you think they are good. Joe, only the first one is for review?
Comment 13 Pavel Feldman 2010-07-18 12:19:20 PDT
Comment on attachment 60809 [details]
[PATCH] Migrate Application Cache

Loislo told me you should rebaseline. Sorry about that!
Comment 14 Joseph Pecoraro 2010-07-18 15:31:20 PDT
Yah, I should rebaseline these, there have been a few (minor) collisions but
certainly some file name changes. I'll try to find some time next week to do
this. When I start it I'll post a comment so you know its being worked on.
Otherwise, if Loislo comes across this section that is okay too. Be advised
there were a few frontend fixes with these patches.
Comment 15 Joseph Pecoraro 2010-08-11 09:46:53 PDT
Intent of this bug was handled by bug 43482, bug 43486, and bug 43541.

*** This bug has been marked as a duplicate of bug 43482 ***