Bug 41805 – Web Inspector: Migrate Storage Panel to InspectorFrontend2

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector (Deprecated)

[Joseph Pecoraro]

Might as well try to add all new interfaces as InspectorFrontend2! This also catches
a few minor idl generator improvements $(FEATURE_DEFINES) for handling compile
time flags in InspectorFrontend2.idl.

I can break this down into separate patches if desired.

[Joseph Pecoraro]

Created attachment 60784 [details]
[PATCH] Migrate InspectorApplicationCacheAgent

Please double check the build changes. I am unfamiliar with many of the
build systems, but I think this was rather straightforward.

I think some should already work:

  GNUmakefile.am               has  $(FEATURE_DEFINES)
  WebCore.pri                  has  $${FEATURE_DEFINES_JAVASCRIPT}}
  cmake/WebKitGenerators.cmake has  ${FEATURE_DEFINES_STR}

[Early Warning System Bot]

Attachment 60784 [details] did not build on qt:
Build output: http://webkit-commit-queue.appspot.com/results/3416358

[Eric Seidel (no email)]

Attachment 60784 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3362454

[Joseph Pecoraro]

The bots failed because this is missing a patch that I haven't landed yet. There is a lot of activity on the bots right now, and that patch is in the queue.

[WebKit Review Bot]

Attachment 60784 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3365442

[WebKit Review Bot]

Attachment 60784 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3380454

[Joseph Pecoraro]

Created attachment 60809 [details]
[PATCH] Migrate Application Cache

Landed the required part in r62731. So re-uploading this so they
test with a (hopefully) ToT try-bot.

[Joseph Pecoraro]

Created attachment 60840 [details]
[PATCH] Migrate Cookies

[Joseph Pecoraro]

Created attachment 60841 [details]
[PATCH] Migrate Databases

[Joseph Pecoraro]

Created attachment 60842 [details]
[PATCH] Migrate DOM Storage

[Joseph Pecoraro]

Miscellaneous minor fixes / improvements:
  - numerous style fixes
  - numerous unnecessary headers
  - addDatabase no longer needs a bool return value, no need to check for an exception
  - addDOMStorage no longer needs a bool return value, ditto
  - added a few "const"s
  - fix DatabaseTableView's statusbar icon

[Pavel Feldman]

Ilya, I can stamp these if you think they are good. Joe, only the first one is for review?

[Pavel Feldman]

Comment on attachment 60809 [details]
[PATCH] Migrate Application Cache

Loislo told me you should rebaseline. Sorry about that!

[Joseph Pecoraro]

Yah, I should rebaseline these, there have been a few (minor) collisions but
certainly some file name changes. I'll try to find some time next week to do
this. When I start it I'll post a comment so you know its being worked on.
Otherwise, if Loislo comes across this section that is okay too. Be advised
there were a few frontend fixes with these patches.

[Joseph Pecoraro]

Intent of this bug was handled by bug 43482, bug 43486, and bug 43541.

*** This bug has been marked as a duplicate of bug 43482 ***