Bug 41778 - Add reverseFind to Vector and deploy in HTML5 parser
Summary: Add reverseFind to Vector and deploy in HTML5 parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-07 11:09 PDT by Adam Barth
Modified: 2010-07-07 15:38 PDT (History)
1 user (show)

See Also:

Attachments
Patch (6.19 KB, patch)
2010-07-07 11:13 PDT, Adam Barth 		sam: review+
abarth: commit-queue+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-07 11:09:15 PDT 
Add reverseFind to Vector and deploy in HTML5 parser
Comment 1 Adam Barth 2010-07-07 11:13:17 PDT 
Created attachment 60757 [details]
Patch
Comment 2 Adam Barth 2010-07-07 12:02:30 PDT 
Comment on attachment 60757 [details]
Patch

Thanks Sam.
Comment 3 Eric Seidel (no email) 2010-07-07 13:11:18 PDT 
Comment on attachment 60757 [details]
Patch

Huh?  I don't understand your comparison change.  How is it possible for find to work with a non-entity type?

What was the speedup of changing the operator?  I guess none, since it was already avoiding the operator in findIndex.
Comment 4 Adam Barth 2010-07-07 14:21:20 PDT 
Committed r62697: <http://trac.webkit.org/changeset/62697>
Comment 5 Adam Barth 2010-07-07 15:38:04 PDT 
I discussed this with Eric on the phone and he's on board now.