Bug 41734 - Implement "act as if the banana has been peeled" (for lack of a better term)
Summary: Implement "act as if the banana has been peeled" (for lack of a better term)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-06 21:29 PDT by Adam Barth
Modified: 2010-07-06 21:43 PDT (History)
1 user (show)

See Also:


Attachments
Patch (22.96 KB, patch)
2010-07-06 21:32 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-06 21:29:19 PDT
Implement "act as if the banana has been peeled" (for lack of a better term)
Comment 1 Adam Barth 2010-07-06 21:32:47 PDT
Created attachment 60677 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-06 21:36:36 PDT
Comment on attachment 60677 [details]
Patch

Split these into local variables:

 858     HTMLConstructionSite::RedirectToFosterParentGuard redirecter(m_tree, m_tree.currentElement()->hasTagName(tableTag) || isTableBodyContextTag(m_tree.currentElement()->localName()) || m_tree.currentElement()->hasTagName(trTag));


Or better yet, and inline function.
Comment 3 Adam Barth 2010-07-06 21:43:19 PDT
Committed r62621: <http://trac.webkit.org/changeset/62621>