Bug 41718 – Mac OS X media controls should have a way to adjust volume incrementally

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Eric Carlson]

Media controls should have a slider to control audio volume, not just a button that toggles mute.

[Eric Carlson]

<rdar://5679472>

[Eric Carlson]

Created attachment 60661 [details]
proposed patch

Comment on attachment 60661 [details]
proposed patch

> +          (WebCore::MediaControlMuteButtonElement::MediaControlMuteButtonElement): Add ButtonLocation 
> +          parameter both mute buttons can be created.

Missing a word there?


> +audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container {
> +    -webkit-appearance: media-volume-slider-container;
> +    position: absolute;
> +
> +    width: 22px;
> +    height: 114px;
> +}

I wonder if this can specify one of top/bottom and one of left/right.

> +IntPoint RenderThemeMac::volumeSliderOffsetFromMuteButton(Node* muteButton, const IntSize& size) const
> +{
> +    static const int xOffset = -4;
> +    static const int yOffset = 5;
> +
> +    int y = muteButton->renderBox()->offsetHeight() + yOffset - size.height();
> +    FloatPoint absPoint = muteButton->renderer()->localToAbsolute(FloatPoint(muteButton->renderBox()->offsetLeft(), y), true, true);
> +    if (absPoint.y() < 0)
> +        y = muteButton->renderBox()->height();
> +    return IntPoint(xOffset, y);
> +}

I think I know what this does but a comment wouldn’t hurt.

r=me!

[Eric Carlson]

http://trac.webkit.org/changeset/62821

[Eric Carlson]

*** Bug 41980 has been marked as a duplicate of this bug. ***