Bug 41688 - Add processing for "in cell" mode and end tag processing for "in row"
Summary: Add processing for "in cell" mode and end tag processing for "in row"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-06 05:36 PDT by Eric Seidel (no email)
Modified: 2010-07-06 11:24 PDT (History)
2 users (show)

See Also:

Attachments
Patch (29.16 KB, patch)
2010-07-06 05:43 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-06 05:36:31 PDT 
Add processing for "in cell" mode and end tag processing for "in row"
Comment 1 Eric Seidel (no email) 2010-07-06 05:43:09 PDT 
Created attachment 60623 [details]
Patch
Comment 2 Adam Barth 2010-07-06 09:43:21 PDT 
Comment on attachment 60623 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:760
 +  void HTMLTreeBuilder::closeTheCell()
I like the insert-to-code ratio in this function.
Comment 3 Adam Barth 2010-07-06 10:28:53 PDT 
Comment on attachment 60623 [details]
Patch

Clearing flags on attachment: 60623

Committed r62563: <http://trac.webkit.org/changeset/62563>
Comment 4 Adam Barth 2010-07-06 10:28:58 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Ms2ger (he/him; ⌚ UTC+1/+2) 2010-07-06 11:11:41 PDT 
(In reply to comment #2)
> (From update of attachment 60623 [details])
> WebCore/html/HTMLTreeBuilder.cpp:760
>  +  void HTMLTreeBuilder::closeTheCell()
> I like the insert-to-code ratio in this function.

And that's without asserting that insertionMode() == InRowMode after processFakeEndTag(tdTag).
Comment 6 Adam Barth 2010-07-06 11:24:10 PDT 
> And that's without asserting that insertionMode() == InRowMode after processFakeEndTag(tdTag).

Patches welcome.  :)