Bug 41659 - Implement bookmarking for HTML5 Adoption Agency algorithm
Summary: Implement bookmarking for HTML5 Adoption Agency algorithm
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Blocks: 41123
  Show dependency treegraph
Reported: 2010-07-06 00:21 PDT by Eric Seidel (no email)
Modified: 2010-07-06 01:54 PDT (History)
3 users (show)

See Also:

Patch (10.06 KB, patch)
2010-07-06 00:23 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch (15.69 KB, patch)
2010-07-06 01:06 PDT, Eric Seidel (no email)
abarth: review+
abarth: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-06 00:21:39 PDT
Implement bookmarking for HTML5 Adoption Agency algorithm
Comment 1 Eric Seidel (no email) 2010-07-06 00:23:37 PDT
Created attachment 60596 [details]
Comment 2 Eric Seidel (no email) 2010-07-06 00:26:44 PDT
Attachment 60596 [details] did not build on mac:
Build output: http://webkit-commit-queue.appspot.com/results/3403276
Comment 3 Adam Barth 2010-07-06 00:30:06 PDT
Comment on attachment 60596 [details]

Your patch needs some work.  :)
Comment 4 Eric Seidel (no email) 2010-07-06 01:06:48 PDT
Created attachment 60601 [details]
Comment 5 Eric Seidel (no email) 2010-07-06 01:07:16 PDT
Yay for fixing 11 tests!
Comment 6 Adam Barth 2010-07-06 01:10:28 PDT
Comment on attachment 60601 [details]

Awesome test progression.  :)

 +              // Bookmarks are not general purpose, only for Adoption Agency.
This isn't really proper english...
Comment 7 Eric Seidel (no email) 2010-07-06 01:17:10 PDT
Committed r62537: <http://trac.webkit.org/changeset/62537>
Comment 8 WebKit Review Bot 2010-07-06 01:39:32 PDT
http://trac.webkit.org/changeset/62537 might have broken Qt Linux Release
Comment 9 Eric Seidel (no email) 2010-07-06 01:54:57 PDT
Committed r62539: <http://trac.webkit.org/changeset/62539>