Bug 41627 - Implement InSelectMode
Summary: Implement InSelectMode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-05 11:29 PDT by Adam Barth
Modified: 2010-07-05 21:58 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.19 KB, patch)
2010-07-05 11:30 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (12.11 KB, patch)
2010-07-05 20:46 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (12.15 KB, patch)
2010-07-05 21:03 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-05 11:29:55 PDT 
Implement InSelectMode
Comment 1 Adam Barth 2010-07-05 11:30:48 PDT 
Created attachment 60559 [details]
Patch
Comment 2 Adam Barth 2010-07-05 20:46:55 PDT 
Created attachment 60577 [details]
Patch
Comment 3 Eric Seidel (no email) 2010-07-05 20:58:47 PDT 
Comment on attachment 60577 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:913
 +              insertElement(token);
Why no return after this?  We need to figure out what the right pattern here is.

WebCore/html/HTMLTreeBuilder.cpp:924
 +              insertElement(token);
Here again?  No return?

Looks OK, I think.
Comment 4 Adam Barth 2010-07-05 21:03:07 PDT 
Created attachment 60578 [details]
Patch for landing
Comment 5 WebKit Commit Bot 2010-07-05 21:58:29 PDT 
Comment on attachment 60578 [details]
Patch for landing

Clearing flags on attachment: 60578

Committed r62519: <http://trac.webkit.org/changeset/62519>
Comment 6 WebKit Commit Bot 2010-07-05 21:58:34 PDT 
All reviewed patches have been landed.  Closing bug.