Bug 41591 - Add </table> support for "in table" insertion mode
Summary: Add </table> support for "in table" insertion mode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-04 21:57 PDT by Eric Seidel (no email)
Modified: 2010-07-05 14:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.95 KB, patch)
2010-07-04 22:02 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff
Patch for landing (7.63 KB, patch)
2010-07-05 11:32 PDT, Eric Seidel (no email)
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-04 21:57:18 PDT
Add </table> support for "in table" insertion mode
Comment 1 Eric Seidel (no email) 2010-07-04 22:02:45 PDT
Created attachment 60493 [details]
Patch
Comment 2 Adam Barth 2010-07-04 22:05:51 PDT
Comment on attachment 60493 [details]
Patch

We're not supposed to return after the fragment mode parse error?
Comment 3 Eric Seidel (no email) 2010-07-05 11:32:49 PDT
Created attachment 60561 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-07-05 12:54:04 PDT
Comment on attachment 60561 [details]
Patch for landing

Rejecting patch 60561 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Last 500 characters of output:
ed.txt
Hunk #1 FAILED at 4940.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej
patching file WebCore/ChangeLog
Hunk #1 FAILED at 1.
Hunk #2 FAILED at 25.
Hunk #3 FAILED at 44.
Hunk #4 FAILED at 66.
4 out of 4 hunks FAILED -- saving rejects to file WebCore/ChangeLog.rej
patching file WebCore/html/HTMLTreeBuilder.cpp
Hunk #1 succeeded at 1064 (offset -29 lines).
Hunk #2 succeeded at 1227 (offset -29 lines).
patching file WebCore/html/HTMLTreeBuilder.h

Full output: http://webkit-commit-queue.appspot.com/results/3391257
Comment 5 Adam Barth 2010-07-05 13:54:37 PDT
Your changelog is all messed up.
Comment 6 Adam Barth 2010-07-05 14:25:27 PDT
Committed r62507: <http://trac.webkit.org/changeset/62507>