Bug 41588 - Add basic "in row" mode to support <td> insertion
Summary: Add basic "in row" mode to support <td> insertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-04 19:22 PDT by Eric Seidel (no email)
Modified: 2010-07-05 13:02 PDT (History)
2 users (show)

See Also:


Attachments
Patch (14.50 KB, patch)
2010-07-04 19:46 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-04 19:22:32 PDT
Add basic "in row" mode to support <td> insertion
Comment 1 Eric Seidel (no email) 2010-07-04 19:46:41 PDT
Created attachment 60489 [details]
Patch
Comment 2 WebKit Commit Bot 2010-07-04 21:59:36 PDT
Comment on attachment 60489 [details]
Patch

Rejecting patch 60489 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
nner-expected.txt
Hunk #1 FAILED at 4936.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej
patching file LayoutTests/html5lib/runner.html
Hunk #1 FAILED at 60.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner.html.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
patching file WebCore/html/HTMLElementStack.cpp
patching file WebCore/html/HTMLElementStack.h
patching file WebCore/html/HTMLTreeBuilder.cpp

Full output: http://webkit-commit-queue.appspot.com/results/3402240
Comment 3 Adam Barth 2010-07-05 11:32:26 PDT
Comment on attachment 60489 [details]
Patch

In theory, this should land fine now that Bug 41582 is in the queue.
Comment 4 WebKit Commit Bot 2010-07-05 12:16:10 PDT
Comment on attachment 60489 [details]
Patch

Rejecting patch 60489 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 1
Last 500 characters of output:
nner-expected.txt
Hunk #1 FAILED at 4936.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner-expected.txt.rej
patching file LayoutTests/html5lib/runner.html
Hunk #1 FAILED at 60.
1 out of 1 hunk FAILED -- saving rejects to file LayoutTests/html5lib/runner.html.rej
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/html/HTMLElementStack.cpp
patching file WebCore/html/HTMLElementStack.h
patching file WebCore/html/HTMLTreeBuilder.cpp

Full output: http://webkit-commit-queue.appspot.com/results/3409265
Comment 5 Eric Seidel (no email) 2010-07-05 12:54:19 PDT
Comment on attachment 60489 [details]
Patch

Cascading failure from earlier flaky test trouble. :(
Comment 6 Adam Barth 2010-07-05 13:02:21 PDT
Comment on attachment 60489 [details]
Patch

Clearing flags on attachment: 60489

Committed r62499: <http://trac.webkit.org/changeset/62499>
Comment 7 Adam Barth 2010-07-05 13:02:27 PDT
All reviewed patches have been landed.  Closing bug.