Bug 41587 - Add basic "in table body" mode to support <tr> insertion
Summary: Add basic "in table body" mode to support <tr> insertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-07-04 18:54 PDT by Eric Seidel (no email)
Modified: 2010-07-05 10:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (8.48 KB, patch)
2010-07-04 19:01 PDT, Eric Seidel (no email) 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-07-04 18:54:45 PDT 
Add basic "in table body" mode to support <tr> insertion
Comment 1 Eric Seidel (no email) 2010-07-04 19:01:35 PDT 
Created attachment 60488 [details]
Patch
Comment 2 Adam Barth 2010-07-04 21:28:12 PDT 
Comment on attachment 60488 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:787
 +              m_openElements.popUntilTableBodyScopeMarker(); // How is there ever anything to pop?
We could add an assert that this is a nop if we want to learn.

WebCore/html/HTMLTreeBuilder.cpp:805
 +          notImplemented(); // process using "in table" rules
Our strategy here has been to move that code into a separate function that we can call.
Comment 3 WebKit Commit Bot 2010-07-04 21:45:48 PDT 
Comment on attachment 60488 [details]
Patch

Clearing flags on attachment: 60488

Committed r62474: <http://trac.webkit.org/changeset/62474>
Comment 4 WebKit Commit Bot 2010-07-04 21:45:53 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Eric Seidel (no email) 2010-07-05 10:56:45 PDT 
Yes, we can (and should) add such an ASSERT at some point. :)