Bug 41520 - [Qt] QScriptEnginePrivate compilation fix
Summary: [Qt] QScriptEnginePrivate compilation fix
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P1 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31863
  Show dependency treegraph
 
Reported: 2010-07-02 05:52 PDT by Jędrzej Nowacki
Modified: 2010-07-02 07:11 PDT (History)
1 user (show)

See Also:


Attachments
Fix v1 (1.98 KB, patch)
2010-07-02 05:54 PDT, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-07-02 05:52:14 PDT
There is a compilation problem. QScriptEnginePrivate::newArray can't be const because it calls setException which is non const.

WebKit-script/JavaScriptCore/qt/api/qscriptengine_p.cpp: In member function ‘QScriptValuePrivate* QScriptEnginePrivate::newArray(uint) const’:
WebKit-script/JavaScriptCore/qt/api/qscriptengine_p.cpp:105: error: passing ‘const QScriptEnginePrivate’ as ‘this’ argument of ‘void QScriptEnginePrivate::setException(const OpaqueJSValue*, unsigned int)’ discards qualifiers
Comment 1 Jędrzej Nowacki 2010-07-02 05:54:55 PDT
Created attachment 60361 [details]
Fix v1
Comment 2 WebKit Commit Bot 2010-07-02 07:11:13 PDT
Comment on attachment 60361 [details]
Fix v1

Clearing flags on attachment: 60361

Committed r62382: <http://trac.webkit.org/changeset/62382>
Comment 3 WebKit Commit Bot 2010-07-02 07:11:17 PDT
All reviewed patches have been landed.  Closing bug.