Bug 41503 - Implement processFakePEndTagIfPInScope
Summary: Implement processFakePEndTagIfPInScope
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-07-01 22:20 PDT by Adam Barth
Modified: 2010-07-02 18:58 PDT (History)
2 users (show)

See Also:


Attachments
Patch (10.92 KB, patch)
2010-07-01 22:22 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-07-01 22:20:29 PDT
Implement processFakePEndTagIfPInScope
Comment 1 Adam Barth 2010-07-01 22:22:15 PDT
Created attachment 60335 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-07-02 00:51:31 PDT
Comment on attachment 60335 [details]
Patch

WebCore/html/HTMLTreeBuilder.cpp:313
 +      if (!m_openElements.inScope(pTag.localName()))
This is sad.  We'll add a QualifiedName version.

WebCore/html/HTMLTreeBuilder.cpp:315
 +      AtomicHTMLToken endP(HTMLToken::EndTag, pTag.localName());
We need an function to handle this token creation for us.  I think AtomicHTMLTokens should be copyable and that would simplify a lot of this code.
Comment 3 WebKit Commit Bot 2010-07-02 03:26:38 PDT
Comment on attachment 60335 [details]
Patch

Clearing flags on attachment: 60335

Committed r62376: <http://trac.webkit.org/changeset/62376>
Comment 4 WebKit Commit Bot 2010-07-02 03:26:43 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Adam Barth 2010-07-02 18:58:13 PDT
> This is sad.  We'll add a QualifiedName version.

Ok.

> WebCore/html/HTMLTreeBuilder.cpp:315
>  +      AtomicHTMLToken endP(HTMLToken::EndTag, pTag.localName());
> We need an function to handle this token creation for us.  I think AtomicHTMLTokens should be copyable and that would simplify a lot of this code.

I don't understand how copyable tokens would help here.  The P end tag gets invented out of whole cloth.