Bug 41436 - Make html5lib/runner dump failure details by default
Summary: Make html5lib/runner dump failure details by default
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on: 41439
Blocks: 41123
  Show dependency treegraph
Reported: 2010-06-30 16:25 PDT by Eric Seidel (no email)
Modified: 2010-07-01 20:00 PDT (History)
5 users (show)

See Also:

Patch (36.96 KB, patch)
2010-06-30 16:27 PDT, Eric Seidel (no email)
abarth: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-30 16:25:45 PDT
Make html5lib/runner dump failure details by default
Comment 1 Eric Seidel (no email) 2010-06-30 16:27:06 PDT
Created attachment 60169 [details]
Comment 2 Eric Seidel (no email) 2010-06-30 16:29:08 PDT
Git gets confused and treats the results as binary. :(  One can pass -a or --text to git diff to see the actual diff.
Comment 3 Adam Barth 2010-06-30 16:30:31 PDT
Comment on attachment 60169 [details]

Ok...  I'd like to see the actual results though.
Comment 4 WebKit Commit Bot 2010-06-30 23:36:26 PDT
Comment on attachment 60169 [details]

Rejecting patch 60169 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Adam Barth', u'--force']" exit_code: 255
Parsed 4 diffs from patch file(s).
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 1.
only literal type is supported now at /Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply line 248.

Full output: http://webkit-commit-queue.appspot.com/results/3369091
Comment 5 Eric Seidel (no email) 2010-06-30 23:43:15 PDT
Committed r62231: <http://trac.webkit.org/changeset/62231>
Comment 6 WebKit Review Bot 2010-07-01 00:01:27 PDT
http://trac.webkit.org/changeset/62231 might have broken Qt Linux Release
Comment 7 Eric Seidel (no email) 2010-07-01 00:03:38 PDT
The failures on the Qt bot show up as binary. :(  So we may need to just roll this out if binary dumps are going to be a problem.  We need to figure out which subtests are causing this file to be treated as binary.
Comment 8 Eric Seidel (no email) 2010-07-01 00:12:22 PDT
Reverted r62231 for reason:

diff thinks runner-expected.txt is binary which makes the results impossible to read

Committed r62232: <http://trac.webkit.org/changeset/62232>
Comment 9 Csaba Osztrogonác 2010-07-01 00:25:32 PDT
I found the root of the problem, line 222 is the culprit. diff say the expected file is binary because of "^@".
Comment 10 Eric Seidel (no email) 2010-07-01 00:30:08 PDT
Some non-printable char in the test1 output:

Test 41 of 113 in resources/tests1.dat failed. Input:
| <!--  
Comment 11 Eric Seidel (no email) 2010-07-01 00:31:51 PDT
Somehow we're spitting out a \0 and not cactching it.  Will fix.
Comment 12 Eric Seidel (no email) 2010-07-01 00:35:48 PDT
I believe it's due to BogusCommentState not handling EOF properly.
Comment 13 Eric Seidel (no email) 2010-07-01 00:37:02 PDT
I suspect this may be fixed by bug 41439.
Comment 14 Eric Seidel (no email) 2010-07-01 01:20:30 PDT
Committed r62237: <http://trac.webkit.org/changeset/62237>
Comment 15 Adam Barth 2010-07-01 20:00:21 PDT
(In reply to comment #12)
> I believe it's due to BogusCommentState not handling EOF properly.

I knew BogusCommentState needed to come in from the cold!