Bug 41429 - Buildfix for !ENABLE(SVG_FOREIGN_OBJECT)
Summary: Buildfix for !ENABLE(SVG_FOREIGN_OBJECT)
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-30 14:25 PDT by Patrick R. Gansterer
Modified: 2010-06-30 16:10 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.11 KB, patch)
2010-06-30 14:26 PDT, Patrick R. Gansterer 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-06-30 14:25:00 PDT 
see patch
Comment 1 Patrick R. Gansterer 2010-06-30 14:26:35 PDT 
Created attachment 60153 [details]
Patch
Comment 2 WebKit Review Bot 2010-06-30 14:28:14 PDT 
Attachment 60153 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTMLElementStack.cpp:165:  Line contains only semicolon. If this should be an empty statement, use { } instead.  [whitespace/semicolon] [5]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Adam Barth 2010-06-30 15:22:26 PDT 
We'll need to think about how to handle this case.  Our parsing of a page shoudn't be different based on the value of that define.
Comment 4 Eric Seidel (no email) 2010-06-30 15:24:10 PDT 
SVGNames should aways define foreignObject, even when it's not compiled in.  This is the wrong fix.
Comment 5 Eric Seidel (no email) 2010-06-30 15:24:32 PDT 
(In reply to comment #4)
> SVGNames should aways define foreignObject, even when it's not compiled in.  This is the wrong fix.

even when support for foreignObject is not compiled in I mean.
Comment 6 WebKit Commit Bot 2010-06-30 15:25:03 PDT 
Comment on attachment 60153 [details]
Patch

Clearing flags on attachment: 60153

Committed r62208: <http://trac.webkit.org/changeset/62208>
Comment 7 WebKit Commit Bot 2010-06-30 15:25:08 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 8 Eric Seidel (no email) 2010-06-30 16:10:08 PDT 
Filed bug 41433 for the proper fix.