Bug 41433 - make_names.pl should ignore pre-processor definitions when generating FooNames.*
Summary: make_names.pl should ignore pre-processor definitions when generating FooNames.*
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-06-30 16:09 PDT by Eric Seidel (no email)
Modified: 2010-07-20 18:00 PDT (History)
2 users (show)

See Also:


Attachments
work in progress (6.75 KB, patch)
2010-06-30 16:11 PDT, Eric Seidel (no email)
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-30 16:09:21 PDT
make_names.pl should ignore pre-processor definitions when generating FooNames.*
Comment 1 Eric Seidel (no email) 2010-06-30 16:11:11 PDT
Created attachment 60162 [details]
work in progress
Comment 2 Adam Barth 2010-06-30 16:12:11 PDT
You should generate names for the extra tags we need in the new tree builder too.
Comment 3 Eric Seidel (no email) 2010-06-30 16:14:47 PDT
This will require changes to make_names to make it ignore preprocessor definitions in the Names case, and not in the ElementFactory case.  I'm not quite sure how to do that yet though.

This is important for making a correctly functioning HTML5 TreeBuilder since it needs to respect "foreignObject" as a name, even if our foreignObject support is disabled.

I'm not actively working on this bug atm, but we'll have to fix it before we can pass the entire libhtml5 test suite in all configurations.
Comment 4 Adam Barth 2010-06-30 16:29:22 PDT
Block against master?