41324 – Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only indended use

Bug 41324 - Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only indended use

Summary: Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser...

Attachments
Patch (14.67 KB, patch) 2010-06-28 18:44 PDT, Eric Seidel (no email)	no flags	Details \| Formatted Diff \| Diff
Patch (22.93 KB, patch) 2010-06-28 19:07 PDT, Eric Seidel (no email)	no flags	Details \| Formatted Diff \| Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Eric Seidel (no email) 2010-06-28 18:41:28 PDT

Rename ContainerNode::addChild to legacyParserAddChild to indicate its parser-only indended use

Comment 1 Eric Seidel (no email) 2010-06-28 18:44:11 PDT

Created attachment 59972 [details]
Patch

Comment 2 Eric Seidel (no email) 2010-06-28 19:07:53 PDT

Created attachment 59975 [details]
Patch

Comment 3 Adam Barth 2010-06-28 19:11:35 PDT

Comment on attachment 59975 [details]
Patch

ok.  Thanks for doing this.

Comment 4 WebKit Commit Bot 2010-06-28 20:25:34 PDT

Comment on attachment 59975 [details]
Patch

Clearing flags on attachment: 59975

Committed r62079: <http://trac.webkit.org/changeset/62079>

Comment 5 WebKit Commit Bot 2010-06-28 20:25:39 PDT

All reviewed patches have been landed.  Closing bug.

Comment 6 Daniel Bates 2010-06-28 20:35:18 PDT

This broke the Qt Release bot.

See <http://build.webkit.org/builders/Qt%20Linux%20Release/builds/14207/steps/compile-webkit/logs/stdio>

Comment 7 WebKit Review Bot 2010-06-28 20:38:24 PDT

http://trac.webkit.org/changeset/62079 might have broken Qt Linux ARMv5 Release and Qt Linux ARMv7 Release

Comment 8 Daniel Bates 2010-06-28 20:58:30 PDT

Attempt to fix the Qt bots committed in changeset 62081 <https://trac.webkit.org/changeset/62081>.