Bug 41277 - Don't dump contents of <script> elements in LayoutTests
Summary: Don't dump contents of <script> elements in LayoutTests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-06-28 01:50 PDT by Adam Barth
Modified: 2010-06-28 02:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.95 KB, patch)
2010-06-28 01:53 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-28 01:50:39 PDT 
Don't dump contents of <script> elements in LayoutTests
Comment 1 Adam Barth 2010-06-28 01:53:05 PDT 
Created attachment 59886 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-28 01:56:06 PDT 
Comment on attachment 59886 [details]
Patch

Is this really the right place to call this?  We never re-push an element?

Seems like we should rename push and pop to somehting differnet in this case.
Comment 3 Adam Barth 2010-06-28 01:58:16 PDT 
> Is this really the right place to call this?  We never re-push an element?

We don't yet.  There might be some crazy stuff in "reconstruct the formatting elements" though.

> Seems like we should rename push and pop to somehting differnet in this case.

Hum...  That's what it's called in the spec.  The spec don't talk about notifying the elements though.
Comment 4 WebKit Commit Bot 2010-06-28 02:56:42 PDT 
Comment on attachment 59886 [details]
Patch

Clearing flags on attachment: 59886

Committed r61990: <http://trac.webkit.org/changeset/61990>
Comment 5 WebKit Commit Bot 2010-06-28 02:56:47 PDT 
All reviewed patches have been landed.  Closing bug.