Bug 41265 - Clean up some loose ends in HTML5 tree builder
Summary: Clean up some loose ends in HTML5 tree builder
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-06-27 12:36 PDT by Adam Barth
Modified: 2010-06-27 16:50 PDT (History)
4 users (show)

See Also:

Attachments
Patch (4.77 KB, patch)
2010-06-27 12:41 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch for landing (5.42 KB, patch)
2010-06-27 16:04 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-27 12:36:01 PDT 
Clean up some loose ends in HTML5 tree builder
Comment 1 Adam Barth 2010-06-27 12:41:13 PDT 
Created attachment 59861 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-27 14:55:44 PDT 
Comment on attachment 59861 [details]
Patch

WebCore/ChangeLog:17
 +              - Originally I thought that comments had speciall processing in the
special

WebCore/html/HTMLTreeBuilder.cpp:622
 +      currentElement()->addChild(HTMLElementFactory::createHTMLElement(QualifiedName(nullAtom, token.name(), xhtmlNamespaceURI), m_document, 0));
Seems we should wrap this in a function.  One which just takes the token.name().  createHTMLElement()?  addHTMLElement()?
Comment 3 Adam Barth 2010-06-27 16:04:08 PDT 
Created attachment 59864 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2010-06-27 16:19:29 PDT 
Comment on attachment 59864 [details]
Patch for landing

Clearing flags on attachment: 59864

Committed r61974: <http://trac.webkit.org/changeset/61974>
Comment 5 WebKit Commit Bot 2010-06-27 16:19:33 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-06-27 16:50:22 PDT 
http://trac.webkit.org/changeset/61974 might have broken GTK Linux 64-bit Debug