RESOLVED FIXED Bug 41265
Clean up some loose ends in HTML5 tree builder 
https://bugs.webkit.org/show_bug.cgi?id=41265
Summary Clean up some loose ends in HTML5 tree builder
Adam Barth
Reported 2010-06-27 12:36:01 PDT
Clean up some loose ends in HTML5 tree builder
Attachments
Patch (4.77 KB, patch)
2010-06-27 12:41 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch for landing (5.42 KB, patch)
2010-06-27 16:04 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-27 12:41:13 PDT
Created attachment 59861 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-27 14:55:44 PDT
Comment on attachment 59861 [details] Patch WebCore/ChangeLog:17 + - Originally I thought that comments had speciall processing in the special WebCore/html/HTMLTreeBuilder.cpp:622 + currentElement()->addChild(HTMLElementFactory::createHTMLElement(QualifiedName(nullAtom, token.name(), xhtmlNamespaceURI), m_document, 0)); Seems we should wrap this in a function. One which just takes the token.name(). createHTMLElement()? addHTMLElement()?
Adam Barth
Comment 3 2010-06-27 16:04:08 PDT
Created attachment 59864 [details] Patch for landing
WebKit Commit Bot
Comment 4 2010-06-27 16:19:29 PDT
Comment on attachment 59864 [details] Patch for landing Clearing flags on attachment: 59864 Committed r61974: <http://trac.webkit.org/changeset/61974>
WebKit Commit Bot
Comment 5 2010-06-27 16:19:33 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 6 2010-06-27 16:50:22 PDT
http://trac.webkit.org/changeset/61974 might have broken GTK Linux 64-bit Debug
Note You need to log in before you can comment on or make changes to this bug.