Bug 41239 - We should parse <html>
Summary: We should parse <html>
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency tree / graph
 
Reported: 2010-06-25 17:30 PDT by Adam Barth
Modified: 2010-06-28 13:08 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.97 KB, patch)
2010-06-25 17:34 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-25 17:30:35 PDT 
We should parse <html>
Comment 1 Adam Barth 2010-06-25 17:34:28 PDT 
Created attachment 59816 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-25 17:39:35 PDT 
Comment on attachment 59816 [details]
Patch

OK.  rs=me.
Comment 3 Adam Barth 2010-06-25 17:48:09 PDT 
Comment on attachment 59816 [details]
Patch

Clearing flags on attachment: 59816

Committed r61925: <http://trac.webkit.org/changeset/61925>
Comment 4 Adam Barth 2010-06-25 17:48:14 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Alexey Proskuryakov 2010-06-28 10:40:41 PDT 
> This patch is hard to test 

Why is it hard to test? Won't an iframe pointing to such a document do it?

Or is it that HTMLTreeBuilder is in a state where nothing works yet?
Comment 6 Adam Barth 2010-06-28 10:46:15 PDT 
> Why is it hard to test? Won't an iframe pointing to such a document do it?

You're presupposing that we could parse an <iframe> tag at this point.  Literally, this patch let us parse the document "<html>" and nothing else.

> Or is it that HTMLTreeBuilder is in a state where nothing works yet?

We're rapidly approaching the point where we can parse HTML5lib's runner.html.  At that point, adding tests will be easy.
Comment 7 Eric Seidel (no email) 2010-06-28 13:08:24 PDT 
We actually cant' run the runner yet, but we're testing it it already:
https://trac.webkit.org/changeset/61989
https://trac.webkit.org/changeset/61991