Bug 41199 – [Qt] QtScript API should be exceptions aware.

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Jędrzej Nowacki]

The QtScript API should be enriched by these functions:

http://doc.qt.nokia.com/4.6/qscriptengine.html#clearExceptions
http://doc.qt.nokia.com/4.6/qscriptengine.html#hasUncaughtException
http://doc.qt.nokia.com/4.6/qscriptengine.html#uncaughtException

[Jędrzej Nowacki]

Created attachment 59895 [details]
Fix v1

[Kent Hansen]

LGTM

[Jędrzej Nowacki]

Comment on attachment 59895 [details]
Fix v1

Patch need to be rebased.

[Jędrzej Nowacki]

Created attachment 60108 [details]
Fix v1.01

Rebased against trunk.

[Simon Hausmann]

Comment on attachment 60108 [details]
Fix v1.01

r=me

[WebKit Commit Bot]

Comment on attachment 60108 [details]
Fix v1.01

Rejecting patch 60108 from commit-queue.

Unexpected failure when processing patch!  Please file a bug against webkit-patch.
Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 60108, '--test', '--parent-command=commit-queue', '--no-update']" exit_code: 1
Last 500 characters of output:
webkitpy/tool/commands/stepsequence.py", line 60, in _run
    step(tool, options).run(state)
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 68, in run
    if self._has_valid_reviewer(changelog_entry):
  File "/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/webkitpy/tool/steps/validatereviewer.py", line 50, in _has_valid_reviewer
    if changelog_entry.reviewer():
AttributeError: 'NoneType' object has no attribute 'reviewer'

[Simon Hausmann]

Committed r62377: <http://trac.webkit.org/changeset/62377>