Bug 41184 - Sketch out InHeadMode for tree builder
Summary: Sketch out InHeadMode for tree builder
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
Depends on:
Blocks: 41123
  Show dependency treegraph
Reported: 2010-06-24 17:01 PDT by Adam Barth
Modified: 2010-06-24 22:33 PDT (History)
1 user (show)

See Also:

Patch (6.20 KB, patch)
2010-06-24 17:03 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-24 17:01:06 PDT
Sketch out InHeadMode for tree builder
Comment 1 Adam Barth 2010-06-24 17:03:21 PDT
Created attachment 59711 [details]
Comment 2 Eric Seidel (no email) 2010-06-24 22:22:31 PDT
Comment on attachment 59711 [details]

 +              // FIXME: Atomize "command".
Silly fixme.  DEFINE_LOCAL(AtomicString, commandAtom, "command") is all you need. :)

Yeah, this is going to be the wrong design.  We're going to want to switch based on tag and then on state, instead of how the spec is written which is state then tag.WebCore/html/HTMLTreeBuilder.cpp:400
 +              break;
This break seems silly.
Comment 3 Adam Barth 2010-06-24 22:33:46 PDT
Comment on attachment 59711 [details]

Clearing flags on attachment: 59711

Committed r61823: <http://trac.webkit.org/changeset/61823>
Comment 4 Adam Barth 2010-06-24 22:33:51 PDT
All reviewed patches have been landed.  Closing bug.