Bug 41131 - Add AtomicHTMLToken
Summary: Add AtomicHTMLToken
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 41123
  Show dependency treegraph
 
Reported: 2010-06-23 23:14 PDT by Adam Barth
Modified: 2010-06-24 15:07 PDT (History)
1 user (show)

See Also:


Attachments
Patch (8.41 KB, patch)
2010-06-23 23:17 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-23 23:14:21 PDT
Add AtomicHTMLToken
Comment 1 Adam Barth 2010-06-23 23:17:00 PDT
Created attachment 59614 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-23 23:20:15 PDT
Comment on attachment 59614 [details]
Patch

I like the idea.  It should have its own header though.

It could be a subclass of HTMLToken, but I think it's nice to be separate like this.  HTMLToken may end up being a struct and internal to the Tokenizer as you suggest.

I'm ready to r+ this, but I think it needs its own header.
Comment 3 Adam Barth 2010-06-23 23:23:41 PDT
> It could be a subclass of HTMLToken, but I think it's nice to be separate like this.  HTMLToken may end up being a struct and internal to the Tokenizer as you suggest.

It can't be a subclass because we don't want the large buffers that HTMLToken has.

> I'm ready to r+ this, but I think it needs its own header.

I could add a separate header, but it's eventually going to eat HTMLToken, so there doesn't seem to be much of a point in adding a new header.
Comment 4 Eric Seidel (no email) 2010-06-23 23:32:00 PDT
(In reply to comment #3)
> > It could be a subclass of HTMLToken, but I think it's nice to be separate like this.  HTMLToken may end up being a struct and internal to the Tokenizer as you suggest.
> 
> It can't be a subclass because we don't want the large buffers that HTMLToken has.

Agreed.

> > I'm ready to r+ this, but I think it needs its own header.
> 
> I could add a separate header, but it's eventually going to eat HTMLToken, so there doesn't seem to be much of a point in adding a new header.

I don't believe you.
Comment 5 Eric Seidel (no email) 2010-06-23 23:32:18 PDT
Comment on attachment 59614 [details]
Patch

I think your lack-of-new-header is mostly being lazy. :p
Comment 6 Adam Barth 2010-06-24 15:07:59 PDT
Committed r61791: <http://trac.webkit.org/changeset/61791>