Bug 41108 – A buffer should be bound to one target in its lifetime

• Status: RESOLVED
• Resolution: FIXED
• Component: WebGL

[Zhenyao Mo]

In WebGL, an attempt to bind a buffer to another target will generate INVALID_OPERATION.

[Zhenyao Mo]

Created attachment 59568 [details]
patch

[Kenneth Russell]

Comment on attachment 59568 [details]
patch

Generally looks good. One comment which will require another revision.


WebCore/html/canvas/WebGLBuffer.h:71
 +          unsigned m_arrayBufferByteLength;
These two byte lengths can be collapsed into one now. This should simplify the logic above.

[Zhenyao Mo]

Created attachment 59587 [details]
revised patch : responding to kbr's review

[Kenneth Russell]

Comment on attachment 59587 [details]
revised patch : responding to kbr's review

This looks good; nice cleanup. However I just noticed there's a typo in one comment which makes it really confusing.


WebCore/html/canvas/WebGLBuffer.cpp:149
 +      // In WebGL, a buffer is bound to its target in its lifetime
should read "one target in its lifetime"

[Zhenyao Mo]

Created attachment 59664 [details]
revised patch: fixed the typo

[Dimitri Glazkov (Google)]

Comment on attachment 59664 [details]
revised patch: fixed the typo

ok.

[WebKit Commit Bot]

Comment on attachment 59664 [details]
revised patch: fixed the typo

Clearing flags on attachment: 59664

Committed r61934: <http://trac.webkit.org/changeset/61934>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.