Bug 40922 - Make WebKit2 be built by build-webkit (so it will be built by build.webkit.org bots)
Summary: Make WebKit2 be built by build-webkit (so it will be built by build.webkit.or...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows XP
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar, PlatformOnly
Depends on: 40921
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-21 08:33 PDT by Adam Roben (:aroben)
Modified: 2010-07-13 00:39 PDT (History)
6 users (show)

See Also:


Attachments
Patch (40.96 KB, patch)
2010-07-12 23:18 PDT, Steve Falkenburg
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Roben (:aroben) 2010-06-21 08:33:44 PDT
We should make WebKit2 be built by build-webkit so it will be built by the build.webkit.org bots. One way to do this is to add WebKit2 to WebKit.sln (though that's a little confusing, since WebKit and WebKit2 are peers).
Comment 1 Adam Roben (:aroben) 2010-06-21 08:34:31 PDT
We probably shouldn't do this until bug 40921 is fixed, as otherwise WebKit2 will take just as long to link as WebKit1, which could slow down the bots a lot.
Comment 2 Adam Roben (:aroben) 2010-06-21 08:35:15 PDT
<rdar://problem/8113039>
Comment 3 Steve Falkenburg 2010-07-12 23:18:49 PDT
Created attachment 61334 [details]
Patch
Comment 4 Maciej Stachowiak 2010-07-12 23:21:04 PDT
Comment on attachment 61334 [details]
Patch

r=me
Comment 5 Steve Falkenburg 2010-07-12 23:32:57 PDT
Committed r63178: <http://trac.webkit.org/changeset/63178>
Comment 6 WebKit Review Bot 2010-07-13 00:39:48 PDT
http://trac.webkit.org/changeset/63178 might have broken Chromium Win Release
The following changes are on the blame list:
http://trac.webkit.org/changeset/63178
http://trac.webkit.org/changeset/63179
http://trac.webkit.org/changeset/63180
http://trac.webkit.org/changeset/63181