RESOLVED FIXED 40921
WebKit1 and WebKit2 should build as a single DLL 
https://bugs.webkit.org/show_bug.cgi?id=40921
Summary WebKit1 and WebKit2 should build as a single DLL
Adam Roben (:aroben)
Reported 2010-06-21 08:31:32 PDT
We should build the WebKit1 and WebKit2 APIs into a single DLL on Windows. This way applications that use both APIs won't pull in two copies of WebCore (with unshared memory caches, etc.). (The other option is to build WebCore as a separate DLL, but I think that would be much harder to do.)
Attachments
Patch (143.45 KB, patch)
2010-07-12 16:39 PDT, Steve Falkenburg 		alice.barraclough: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2010-06-21 08:34:58 PDT
<rdar://problem/8113038>
Steve Falkenburg
Comment 2 2010-07-12 16:39:38 PDT
Created attachment 61288 [details] Patch
Alice Liu
Comment 3 2010-07-12 17:15:59 PDT
Comment on attachment 61288 [details] Patch > Index: WebKit2/ChangeLog > =================================================================== > @@ -1,3 +1,56 @@ > + * win/WebKit2.def: Added. Copied from WebKit project. > + * win/WebKit2.rc: Added resources previously in WebKit. > + * win/WebKit2.vcproj: Changed project name to WebKit so we will link output to WebKit.dll. > + Removed implementations overlapping with WebKitLib (WebCoreLocalizedStrings, DllMain, WebLocalizableStrings, WebProcessMain). > + * win/WebKit2Common.vsprops: Use a framework name of WebKit instead of WebKit2 to reflect project name. > + Renamed BUILDING_WEBKIT2 to BUILDING_WEBKIT since there is now just a single WebKit.dll. > + * win/WebKit2WebProcess.vcproj: Link against WebKit instead of WebKit2 due to renaming. I find it inconsistent that we're building the WebKit2 dll as WebKit.dll, but we're still calling several of these files "WebKit2(.*)". Could you rename these files without the 2. follow-up patch is fine with me. > Index: WebKit/win/WebKit.vcproj/WebKit.vcproj > =================================================================== > - <File > - RelativePath=".\nullplugin.png" > - > > - </File> the other pan*.pngs added in WebKit2.vcproj don't seem to be removed from WebKit.vcproj. > - <File > - RelativePath=".\searchCancel.png" > - > > - </File>
Steve Falkenburg
Comment 4 2010-07-12 21:59:29 PDT
http://trac.webkit.org/changeset/63151
Simon Fraser (smfr)
Comment 5 2012-10-08 15:17:41 PDT
Roger, Tim and I have been confused for weeks now about why we couldn't find WebKit.def any more. Using WebKit2.def makes no sense.
Note You need to log in before you can comment on or make changes to this bug.