Bug 40903 - [Qt] QScriptValue should have API for accessing object properties
Summary: [Qt] QScriptValue should have API for accessing object properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt, QtTriaged
Depends on: 40613
Blocks: 31863
  Show dependency treegraph
 
Reported: 2010-06-21 00:53 PDT by Kent Hansen
Modified: 2010-07-06 07:20 PDT (History)
6 users (show)

See Also:


Attachments
Partial patch v1 (8.32 KB, patch)
2010-06-21 22:05 PDT, Caio Marcelo de Oliveira Filho
no flags Details | Formatted Diff | Diff
Fix v2 (64.25 KB, patch)
2010-07-06 00:53 PDT, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 Caio Marcelo de Oliveira Filho 2010-06-21 22:05:27 PDT
Created attachment 59336 [details]
Partial patch v1

This implements just the ResolvePrototype case for property(), still need to dig the C API for a way to get the own property only. However, as is, it's already useful to enhance our tests of other features.
Comment 2 Jędrzej Nowacki 2010-06-22 01:43:17 PDT
(In reply to comment #1)
> Created an attachment (id=59336) [details]
> Partial patch v1
> 
> This implements just the ResolvePrototype case for property(), still need to dig the C API for a way to get the own property only. However, as is, it's already useful to enhance our tests of other features.

Looks good to me :-).

Next time we should be more in sync as I have a patch for this bug (it contains setProperty too). I will rebase mine after yours will be applied. Thanks!
Comment 3 WebKit Commit Bot 2010-06-28 08:20:10 PDT
Comment on attachment 59336 [details]
Partial patch v1

Clearing flags on attachment: 59336

Committed r62007: <http://trac.webkit.org/changeset/62007>
Comment 4 WebKit Commit Bot 2010-06-28 08:20:15 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Caio Marcelo de Oliveira Filho 2010-06-28 10:44:32 PDT
Thanks, folks. But we probably should keep this bugs open so Jędrzej can land the other patch. :-)
Comment 6 Jędrzej Nowacki 2010-07-06 00:48:28 PDT
(In reply to comment #5)
> Thanks, folks. But we probably should keep this bugs open so Jędrzej can land the other patch. :-)
yes, it would be nice ;-)
Comment 7 Jędrzej Nowacki 2010-07-06 00:53:02 PDT
Created attachment 60600 [details]
Fix v2

I added setProperty() and a few additional flags
Comment 8 Kent Hansen 2010-07-06 01:26:54 PDT
(In reply to comment #7)
> Created an attachment (id=60600) [details]
> Fix v2
> 
> I added setProperty() and a few additional flags

Looks good!
Comment 9 Kenneth Rohde Christiansen 2010-07-06 06:37:48 PDT
Comment on attachment 60600 [details]
Fix v2

Great testing as always.
Comment 10 WebKit Commit Bot 2010-07-06 06:55:45 PDT
Comment on attachment 60600 [details]
Fix v2

Clearing flags on attachment: 60600

Committed r62547: <http://trac.webkit.org/changeset/62547>
Comment 11 WebKit Commit Bot 2010-07-06 06:55:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 12 WebKit Review Bot 2010-07-06 07:20:47 PDT
http://trac.webkit.org/changeset/62547 might have broken GTK Linux 64-bit Debug