RESOLVED FIXED 40650
Enable HTML5 lexer 
https://bugs.webkit.org/show_bug.cgi?id=40650
Summary Enable HTML5 lexer
Adam Barth
Reported Wednesday, June 16, 2010 4:58:34 AM UTC
Enable HTML5 lexer
Attachments
Patch (51.79 KB, patch)
2010-06-15 21:53 PDT, Adam Barth 		eric: review+
eric: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 Wednesday, June 16, 2010 5:53:51 AM UTC
Created attachment 58850 [details] Patch
Eric Seidel (no email)
Comment 2 Wednesday, June 16, 2010 7:19:58 AM UTC
Comment on attachment 58850 [details] Patch LayoutTests/ChangeLog:61 + * inspector/timeline-script-tag-1-expected.txt: Our new behavior is fine. We just need to file a bug with the inspector to update their code a bit. LayoutTests/ChangeLog:60 + * inspector/audits-panel-functional-expected.txt: Did the explanation for this one go in the wrong place? Do we need a bug on this? LayoutTests/ChangeLog:44 + - I don't fully understand this behavior change. It might We should file a bug for this. LayoutTests/ChangeLog:101 + FFFD). Still investigating whether this is a real bug. We should probably turn all of these investigations into bugs at this point, since we're actually changing what everyone is using in their day-to-day builds. rs=me. I've seen all these changes for a while and they look expected. But we should be sure to send a note to webkit-dev pointing them to this change so they can comment about any of these behavioral changes. Thanks for putting this together.WebCore/page/Settings.cpp:135 + , m_html5ParserEnabled(true) Do we need to change WebKit as well? I think we might. Certainly we need to rename this setting at some point. If you file a bug on it or add it to the TODO list I can take care of it.
Eric Seidel (no email)
Comment 3 Wednesday, June 16, 2010 7:21:07 AM UTC
We should consider closing the master bug after landing this too. :)
Adam Barth
Comment 4 Wednesday, June 16, 2010 7:27:51 AM UTC
Committed r61234: <http://trac.webkit.org/changeset/61234>
WebKit Review Bot
Comment 5 Wednesday, June 16, 2010 7:47:39 AM UTC
http://trac.webkit.org/changeset/61234 might have broken Qt Linux Release
Adam Barth
Comment 6 Wednesday, June 16, 2010 7:49:17 AM UTC
Fixenating.
Adam Barth
Comment 7 Wednesday, June 16, 2010 7:51:40 AM UTC
Committed r61235: <http://trac.webkit.org/changeset/61235>
Adam Barth
Comment 8 Wednesday, June 16, 2010 8:05:03 AM UTC
Committed r61236: <http://trac.webkit.org/changeset/61236>
Adam Barth
Comment 9 Wednesday, June 16, 2010 8:30:18 AM UTC
Committed r61237: <http://trac.webkit.org/changeset/61237>
Eric Seidel (no email)
Comment 10 Wednesday, June 16, 2010 8:51:26 AM UTC
Committed r61238: <http://trac.webkit.org/changeset/61238>
Adam Barth
Comment 11 Wednesday, June 16, 2010 9:06:29 AM UTC
Committed r61240: <http://trac.webkit.org/changeset/61240>
Eric Seidel (no email)
Comment 12 Wednesday, June 16, 2010 9:25:31 AM UTC
Committed r61242: <http://trac.webkit.org/changeset/61242>
Adam Barth
Comment 13 Wednesday, June 16, 2010 9:48:29 AM UTC
Committed r61243: <http://trac.webkit.org/changeset/61243>
Adam Barth
Comment 14 Wednesday, June 16, 2010 9:59:33 AM UTC
Committed r61245: <http://trac.webkit.org/changeset/61245>
Adam Barth
Comment 15 Wednesday, June 16, 2010 4:32:53 PM UTC
Committed r61257: <http://trac.webkit.org/changeset/61257>
Adam Barth
Comment 16 Wednesday, June 16, 2010 7:05:28 PM UTC
Committed r61264: <http://trac.webkit.org/changeset/61264>
Note You need to log in before you can comment on or make changes to this bug.