Bug 40650 - Enable HTML5 lexer
Summary: Enable HTML5 lexer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency treegraph
 
Reported: 2010-06-15 20:58 PDT by Adam Barth
Modified: 2010-06-16 11:05 PDT (History)
4 users (show)

See Also:


Attachments
Patch (51.79 KB, patch)
2010-06-15 21:53 PDT, Adam Barth
eric: review+
eric: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-15 20:58:34 PDT
Enable HTML5 lexer
Comment 1 Adam Barth 2010-06-15 21:53:51 PDT
Created attachment 58850 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-15 23:19:58 PDT
Comment on attachment 58850 [details]
Patch

LayoutTests/ChangeLog:61
 +          * inspector/timeline-script-tag-1-expected.txt:
Our new behavior is fine.  We just need to file a bug with the inspector to update their code a bit.

LayoutTests/ChangeLog:60
 +          * inspector/audits-panel-functional-expected.txt:
Did the explanation for this one go in the wrong place?  Do we need a bug on this?

LayoutTests/ChangeLog:44
 +              - I don't fully understand this behavior change.  It might
We should file a bug for this.

LayoutTests/ChangeLog:101
 +                FFFD).  Still investigating whether this is a real bug.
We should probably turn all of these investigations into bugs at this point, since we're actually changing what everyone is using in their day-to-day builds.

rs=me.

I've seen all these changes for a while and they look expected.  But we should be sure to send a note to webkit-dev pointing them to this change so they can comment about any of these behavioral changes.

Thanks for putting this together.WebCore/page/Settings.cpp:135
 +      , m_html5ParserEnabled(true)
Do we need to change WebKit as well?  I think we might.  Certainly we need to rename this setting at some point.  If you file a bug on it or add it to the TODO list I can take care of it.
Comment 3 Eric Seidel (no email) 2010-06-15 23:21:07 PDT
We should consider closing the master bug after landing this too. :)
Comment 4 Adam Barth 2010-06-15 23:27:51 PDT
Committed r61234: <http://trac.webkit.org/changeset/61234>
Comment 5 WebKit Review Bot 2010-06-15 23:47:39 PDT
http://trac.webkit.org/changeset/61234 might have broken Qt Linux Release
Comment 6 Adam Barth 2010-06-15 23:49:17 PDT
Fixenating.
Comment 7 Adam Barth 2010-06-15 23:51:40 PDT
Committed r61235: <http://trac.webkit.org/changeset/61235>
Comment 8 Adam Barth 2010-06-16 00:05:03 PDT
Committed r61236: <http://trac.webkit.org/changeset/61236>
Comment 9 Adam Barth 2010-06-16 00:30:18 PDT
Committed r61237: <http://trac.webkit.org/changeset/61237>
Comment 10 Eric Seidel (no email) 2010-06-16 00:51:26 PDT
Committed r61238: <http://trac.webkit.org/changeset/61238>
Comment 11 Adam Barth 2010-06-16 01:06:29 PDT
Committed r61240: <http://trac.webkit.org/changeset/61240>
Comment 12 Eric Seidel (no email) 2010-06-16 01:25:31 PDT
Committed r61242: <http://trac.webkit.org/changeset/61242>
Comment 13 Adam Barth 2010-06-16 01:48:29 PDT
Committed r61243: <http://trac.webkit.org/changeset/61243>
Comment 14 Adam Barth 2010-06-16 01:59:33 PDT
Committed r61245: <http://trac.webkit.org/changeset/61245>
Comment 15 Adam Barth 2010-06-16 08:32:53 PDT
Committed r61257: <http://trac.webkit.org/changeset/61257>
Comment 16 Adam Barth 2010-06-16 11:05:28 PDT
Committed r61264: <http://trac.webkit.org/changeset/61264>