Bug 40632 - [chromium] WebURL should have a < operator
Summary: [chromium] WebURL should have a < operator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 40861 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-15 11:54 PDT by Jay Civelli
Modified: 2010-06-19 10:11 PDT (History)
4 users (show)

See Also:


Attachments
Initial patch (3.09 KB, patch)
2010-06-15 12:01 PDT, Jay Civelli
fishd: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Fixed ChangeLog (2.76 KB, patch)
2010-06-18 10:27 PDT, Jay Civelli
fishd: review+
jcivelli: commit-queue-
Details | Formatted Diff | Diff
Fixed bug: comparing "a" and "aa" would return strings as equal. (2.67 KB, patch)
2010-06-18 15:12 PDT, Jay Civelli
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jay Civelli 2010-06-15 11:54:04 PDT
WebURL should have a < operator so it can be used in std::maps.
Comment 1 Jay Civelli 2010-06-15 12:01:33 PDT
Created attachment 58803 [details]
Initial patch
Comment 2 WebKit Commit Bot 2010-06-18 04:15:50 PDT
Comment on attachment 58803 [details]
Initial patch

Rejecting patch 58803 from commit-queue.

Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1
Last 500 characters of output:
geLog
	M	WebKit/chromium/public/WebCString.h
	M	WebKit/chromium/public/WebURL.h
	M	WebKit/chromium/src/WebCString.cpp
A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output:
svnlook: Can't write to stream: Broken pipe

    The following ChangeLog files contain OOPS:

        trunk/WebKit/chromium/ChangeLog

    Please don't ever say "OOPS" in a ChangeLog file.
 at /usr/local/git/libexec/git-core/git-svn line 570


Full output: http://webkit-commit-queue.appspot.com/results/3273301
Comment 3 Jay Civelli 2010-06-18 10:27:25 PDT
Created attachment 59130 [details]
Fixed ChangeLog
Comment 4 Jay Civelli 2010-06-18 15:12:52 PDT
Created attachment 59161 [details]
Fixed bug: comparing "a" and "aa" would return strings as equal.

Changed the code to use strcmp instead of strncmp since CString are NULL terminated.
Comment 5 Adam Barth 2010-06-18 15:21:02 PDT
No fishd review for WebKit API change?
Comment 6 Adam Barth 2010-06-18 15:21:19 PDT
And I'm blind.  Sorry for the noise.
Comment 7 Jay Civelli 2010-06-18 15:41:00 PDT
*** Bug 40861 has been marked as a duplicate of this bug. ***
Comment 8 WebKit Commit Bot 2010-06-19 10:11:45 PDT
Comment on attachment 59161 [details]
Fixed bug: comparing "a" and "aa" would return strings as equal.

Clearing flags on attachment: 59161

Committed r61495: <http://trac.webkit.org/changeset/61495>
Comment 9 WebKit Commit Bot 2010-06-19 10:11:50 PDT
All reviewed patches have been landed.  Closing bug.