RESOLVED FIXED 40632
[chromium] WebURL should have a < operator 
https://bugs.webkit.org/show_bug.cgi?id=40632
Summary [chromium] WebURL should have a < operator
Jay Civelli
Reported 2010-06-15 11:54:04 PDT
WebURL should have a < operator so it can be used in std::maps.
Attachments
Initial patch (3.09 KB, patch)
2010-06-15 12:01 PDT, Jay Civelli 		fishd: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
Fixed ChangeLog (2.76 KB, patch)
2010-06-18 10:27 PDT, Jay Civelli 		fishd: review+
jcivelli: commit-queue-
DetailsFormatted DiffDiff
Fixed bug: comparing "a" and "aa" would return strings as equal. (2.67 KB, patch)
2010-06-18 15:12 PDT, Jay Civelli 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Jay Civelli
Comment 1 2010-06-15 12:01:33 PDT
Created attachment 58803 [details] Initial patch
WebKit Commit Bot
Comment 2 2010-06-18 04:15:50 PDT
Comment on attachment 58803 [details] Initial patch Rejecting patch 58803 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: geLog M WebKit/chromium/public/WebCString.h M WebKit/chromium/public/WebURL.h M WebKit/chromium/src/WebCString.cpp A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebKit/chromium/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 570 Full output: http://webkit-commit-queue.appspot.com/results/3273301
Jay Civelli
Comment 3 2010-06-18 10:27:25 PDT
Created attachment 59130 [details] Fixed ChangeLog
Jay Civelli
Comment 4 2010-06-18 15:12:52 PDT
Created attachment 59161 [details] Fixed bug: comparing "a" and "aa" would return strings as equal. Changed the code to use strcmp instead of strncmp since CString are NULL terminated.
Adam Barth
Comment 5 2010-06-18 15:21:02 PDT
No fishd review for WebKit API change?
Adam Barth
Comment 6 2010-06-18 15:21:19 PDT
And I'm blind. Sorry for the noise.
Jay Civelli
Comment 7 2010-06-18 15:41:00 PDT
*** Bug 40861 has been marked as a duplicate of this bug. ***
WebKit Commit Bot
Comment 8 2010-06-19 10:11:45 PDT
Comment on attachment 59161 [details] Fixed bug: comparing "a" and "aa" would return strings as equal. Clearing flags on attachment: 59161 Committed r61495: <http://trac.webkit.org/changeset/61495>
WebKit Commit Bot
Comment 9 2010-06-19 10:11:50 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.