Bug 40622 – Fix return values of functions returning bool instead of pointer

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector (Deprecated)

[Lucas De Marchi]

Fix return values of functions returning bool instead of pointer

[Lucas De Marchi]

Created attachment 58779 [details]
Patch

[Lucas De Marchi]

When compiling WebKit the following warnings were appearing:


WebCore/inspector/InspectorValues.cpp: In member function ‘WTF::PassRefPtr<WebCore::InspectorArray> WebCore::InspectorObject::getArray(const WebCore::String&) const’:
WebCore/inspector/InspectorValues.cpp:610:16: warning: converting ‘false’ to pointer type for argument 1 of ‘WTF::PassRefPtr<T>::PassRefPtr(T*) [with T = WebCore::InspectorArray]’

The patch sent fixes this issue.

[David Levin]

Comment on attachment 58779 [details]
Patch

> diff --git a/WebCore/ChangeLog b/WebCore/ChangeLog
> index caf28db0f3ab1d011b49ab785eea0623352db82f..9d744124996a7431e9b4f2ff81ed67a52061ce58 100644
> --- a/WebCore/ChangeLog
> +++ b/WebCore/ChangeLog
> @@ -1,3 +1,17 @@
> [phone]  Lucas De Marchi  <[e-mail]>
> +
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Return 0 instead of false when functions return a pointer instead of
> +        a boolean value.
> +        https://bugs.webkit.org/show_bug.cgi?id=40622
> +
> +        No new tests since this just removes compiler warnings.

Typically you'd say "No change in functionality so no new tests."

[WebKit Commit Bot]

Comment on attachment 58779 [details]
Patch

Rejecting patch 58779 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/inspector/InspectorValues.cpp
Hunk #1 FAILED at 599.
Hunk #2 FAILED at 607.
2 out of 2 hunks FAILED -- saving rejects to file WebCore/inspector/InspectorValues.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/3341328

[Lucas De Marchi]

(In reply to comment #4)
> (From update of attachment 58779 [details])
> Rejecting patch 58779 from commit-queue.
> 
> Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1

A similar patch was first on commit queue and was applied today.

*** This bug has been marked as a duplicate of bug 40503 ***

[Lucas De Marchi]

Comment on attachment 58779 [details]
Patch

clearing flags.