Bug 40503 – Fix various warnings that are reported when building with clang

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Nico Weber]

Fix various warnings that are reported when building with clang

[Nico Weber]

Created attachment 58519 [details]
Patch (incomplete, hence no r? yet)

[Nico Weber]

Created attachment 58527 [details]
patch

[Nico Weber]

Created attachment 58528 [details]
patch

[Eric Seidel (no email)]

Comment on attachment 58528 [details]
patch

WebCore/bindings/v8/NPV8Object.cpp: 
 +      static WrapperTypeInfo typeInfo = { 0, 0, false };
Can't we just change the expected type to be a bool?  That would be cleaner.

Otherwise looks fine.

[Nico Weber]

No, since

        ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object> object)

in bindings/v8/WrapperTypeInfo.h calls toActiveDOMObjectFunction as function pointer. Were it a bool, it couldn't be called.

[Eric Seidel (no email)]

Comment on attachment 58528 [details]
patch

OK.

[Nico Weber]

Created attachment 58543 [details]
const_cast

[Daniel Bates]

Comment on attachment 58543 [details]
const_cast

  
>  class AnimationBase : public RefCounted<AnimationBase> {
>      friend class CompositeAnimation;
> 
> Property changes on: WebCore/platform/KillRing.h
> ___________________________________________________________________
> Added: svn:eol-style
>    + LF
> 
> 
> Property changes on: WebCore/platform/KillRingNone.cpp
> ___________________________________________________________________
> Added: svn:eol-style
>    + LF

This cannot be landed by the commit-queue because it contains property changes. Moreover, why does this patch change the end-of-line property on these files?

[Nico Weber]

Created attachment 58753 [details]
patch

The prop changes are unrelated. Since the commit queue just ignores them, I thought they are harmless to leave in (I think I've left them in before). Anyway, removed.

[Kent Tamura]

Comment on attachment 58753 [details]
patch

OK

[Eric Seidel (no email)]

Comment on attachment 58528 [details]
patch

Cleared Eric Seidel's review+ from obsolete attachment 58528 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[WebKit Commit Bot]

Comment on attachment 58753 [details]
patch

Clearing flags on attachment: 58753

Committed r61360: <http://trac.webkit.org/changeset/61360>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Lucas De Marchi]

*** Bug 40622 has been marked as a duplicate of this bug. ***