Bug 40503 - Fix various warnings that are reported when building with clang
Summary: Fix various warnings that are reported when building with clang
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nico Weber
URL:
Keywords:
: 40622 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-11 15:38 PDT by Nico Weber
Modified: 2010-06-18 04:26 PDT (History)
2 users (show)

See Also:


Attachments
Patch (incomplete, hence no r? yet) (12.09 KB, patch)
2010-06-11 16:04 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
patch (12.90 KB, patch)
2010-06-11 16:47 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
patch (11.80 KB, patch)
2010-06-11 16:50 PDT, Nico Weber
no flags Details | Formatted Diff | Diff
const_cast (11.83 KB, patch)
2010-06-11 23:35 PDT, Nico Weber
dbates: commit-queue-
Details | Formatted Diff | Diff
patch (11.53 KB, patch)
2010-06-14 22:29 PDT, Nico Weber
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nico Weber 2010-06-11 15:38:02 PDT
Fix various warnings that are reported when building with clang
Comment 1 Nico Weber 2010-06-11 16:04:18 PDT
Created attachment 58519 [details]
Patch (incomplete, hence no r? yet)
Comment 2 Nico Weber 2010-06-11 16:47:54 PDT
Created attachment 58527 [details]
patch
Comment 3 Nico Weber 2010-06-11 16:50:06 PDT
Created attachment 58528 [details]
patch
Comment 4 Eric Seidel (no email) 2010-06-11 16:53:25 PDT
Comment on attachment 58528 [details]
patch

WebCore/bindings/v8/NPV8Object.cpp: 
 +      static WrapperTypeInfo typeInfo = { 0, 0, false };
Can't we just change the expected type to be a bool?  That would be cleaner.

Otherwise looks fine.
Comment 5 Nico Weber 2010-06-11 16:56:50 PDT
No, since

        ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object> object)

in bindings/v8/WrapperTypeInfo.h calls toActiveDOMObjectFunction as function pointer. Were it a bool, it couldn't be called.
Comment 6 Eric Seidel (no email) 2010-06-11 16:57:41 PDT
Comment on attachment 58528 [details]
patch

OK.
Comment 7 Nico Weber 2010-06-11 23:35:25 PDT
Created attachment 58543 [details]
const_cast
Comment 8 Daniel Bates 2010-06-11 23:48:00 PDT
Comment on attachment 58543 [details]
const_cast

  
>  class AnimationBase : public RefCounted<AnimationBase> {
>      friend class CompositeAnimation;
> 
> Property changes on: WebCore/platform/KillRing.h
> ___________________________________________________________________
> Added: svn:eol-style
>    + LF
> 
> 
> Property changes on: WebCore/platform/KillRingNone.cpp
> ___________________________________________________________________
> Added: svn:eol-style
>    + LF

This cannot be landed by the commit-queue because it contains property changes. Moreover, why does this patch change the end-of-line property on these files?
Comment 9 Nico Weber 2010-06-14 22:29:13 PDT
Created attachment 58753 [details]
patch

The prop changes are unrelated. Since the commit queue just ignores them, I thought they are harmless to leave in (I think I've left them in before). Anyway, removed.
Comment 10 Kent Tamura 2010-06-14 22:33:39 PDT
Comment on attachment 58753 [details]
patch

OK
Comment 11 Eric Seidel (no email) 2010-06-16 03:16:11 PDT
Comment on attachment 58528 [details]
patch

Cleared Eric Seidel's review+ from obsolete attachment 58528 [details] so that this bug does not appear in http://webkit.org/pending-commit.
Comment 12 WebKit Commit Bot 2010-06-17 17:01:07 PDT
Comment on attachment 58753 [details]
patch

Clearing flags on attachment: 58753

Committed r61360: <http://trac.webkit.org/changeset/61360>
Comment 13 WebKit Commit Bot 2010-06-17 17:01:12 PDT
All reviewed patches have been landed.  Closing bug.
Comment 14 Lucas De Marchi 2010-06-18 04:26:11 PDT
*** Bug 40622 has been marked as a duplicate of this bug. ***