Bug 40559 - Refactor layout tests for printing to use common code.
Summary: Refactor layout tests for printing to use common code.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-14 01:33 PDT by Hayato Ito
Modified: 2010-07-23 22:17 PDT (History)
3 users (show)

See Also:


Attachments
refactor-layouttests-for-printing (28.98 KB, patch)
2010-06-14 01:38 PDT, Hayato Ito
no flags Details | Formatted Diff | Diff
refactor-layouttests-for-printing-fix-output-order (29.86 KB, patch)
2010-06-14 05:43 PDT, Hayato Ito
hamaji: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hayato Ito 2010-06-14 01:33:17 PDT
Refactor layout tests for printing to use common code.

Layout tests in printing/css2.1/ uses LayoutTests/printing/resources/page-media-test-utils.js, but other tests in printing don't use that JS.
It is better to share code between them.
Comment 1 Hayato Ito 2010-06-14 01:38:52 PDT
Created attachment 58627 [details]
refactor-layouttests-for-printing
Comment 2 Hayato Ito 2010-06-14 01:49:03 PDT
FYI.  The patch is splitted from the following patch, including only refactoring and some minor refinements.

https://bugs.webkit.org/show_bug.cgi?id=39735
https://bug-39735-attachments.webkit.org/attachment.cgi?id=57215
Comment 3 Shinichiro Hamaji 2010-06-14 04:13:36 PDT
Comment on attachment 58627 [details]
refactor-layouttests-for-printing

LayoutTests/printing/numberOfPages-expected.txt:10
 +  PASS: number of pages is 2
It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?
Comment 4 Hayato Ito 2010-06-14 05:43:59 PDT
Created attachment 58638 [details]
refactor-layouttests-for-printing-fix-output-order
Comment 5 Hayato Ito 2010-06-14 05:46:41 PDT
Sure. I've changed the order of the execution. Could you review it?

(In reply to comment #3)
> (From update of attachment 58627 [details])
> LayoutTests/printing/numberOfPages-expected.txt:10
>  +  PASS: number of pages is 2
> It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?

(In reply to comment #3)
> (From update of attachment 58627 [details])
> LayoutTests/printing/numberOfPages-expected.txt:10
>  +  PASS: number of pages is 2
> It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?
Comment 6 Shinichiro Hamaji 2010-06-14 05:55:17 PDT
Comment on attachment 58638 [details]
refactor-layouttests-for-printing-fix-output-order

Looks good to me. Thanks for updating!
Comment 7 Shinichiro Hamaji 2010-06-17 00:00:35 PDT
Committed r61309: <http://trac.webkit.org/changeset/61309>
Comment 8 Daniel Bates 2010-07-23 22:17:52 PDT
Comment on attachment 58638 [details]
refactor-layouttests-for-printing-fix-output-order

Clearing commit-queue flag to get this out of the commit-queue.