Bug 40559 – Refactor layout tests for printing to use common code.

• Status: RESOLVED
• Resolution: FIXED
• Component: Printing

[Hayato Ito]

Refactor layout tests for printing to use common code.

Layout tests in printing/css2.1/ uses LayoutTests/printing/resources/page-media-test-utils.js, but other tests in printing don't use that JS.
It is better to share code between them.

[Hayato Ito]

Created attachment 58627 [details]
refactor-layouttests-for-printing

[Hayato Ito]

FYI.  The patch is splitted from the following patch, including only refactoring and some minor refinements.

https://bugs.webkit.org/show_bug.cgi?id=39735
https://bug-39735-attachments.webkit.org/attachment.cgi?id=57215

[Shinichiro Hamaji]

Comment on attachment 58627 [details]
refactor-layouttests-for-printing

LayoutTests/printing/numberOfPages-expected.txt:10
 +  PASS: number of pages is 2
It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?

[Hayato Ito]

Created attachment 58638 [details]
refactor-layouttests-for-printing-fix-output-order

[Hayato Ito]

Sure. I've changed the order of the execution. Could you review it?

(In reply to comment #3)
> (From update of attachment 58627 [details])
> LayoutTests/printing/numberOfPages-expected.txt:10
>  +  PASS: number of pages is 2
> It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?

(In reply to comment #3)
> (From update of attachment 58627 [details])
> LayoutTests/printing/numberOfPages-expected.txt:10
>  +  PASS: number of pages is 2
> It's not good to have messages after "TEST COMPLETE". Cannot we avoid this?

[Shinichiro Hamaji]

Comment on attachment 58638 [details]
refactor-layouttests-for-printing-fix-output-order

Looks good to me. Thanks for updating!

[Shinichiro Hamaji]

Committed r61309: <http://trac.webkit.org/changeset/61309>

[Daniel Bates]

Comment on attachment 58638 [details]
refactor-layouttests-for-printing-fix-output-order

Clearing commit-queue flag to get this out of the commit-queue.