Bug 40454 - Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser
Summary: Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on: 40462
Blocks: 39259
  Show dependency treegraph
 
Reported: 2010-06-10 17:12 PDT by Tony Gentilcore
Modified: 2010-06-11 11:46 PDT (History)
4 users (show)

See Also:


Attachments
Patch (5.54 KB, patch)
2010-06-10 17:16 PDT, Tony Gentilcore
no flags Details | Formatted Diff | Diff
Preserve check for null tokenizer (5.42 KB, patch)
2010-06-11 09:04 PDT, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-06-10 17:12:19 PDT
Fix fast/forms/preserveFormDuringResidualStyle.html
Comment 1 Tony Gentilcore 2010-06-10 17:16:53 PDT
Created attachment 58423 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-10 17:24:39 PDT
Comment on attachment 58423 [details]
Patch

Wonderful!
Comment 3 Adam Barth 2010-06-10 18:17:22 PDT
Oh man.  Maybe we should grep the codebase for static_cast<HTMLTokenizer*>
Comment 4 Adam Barth 2010-06-10 22:29:01 PDT
Comment on attachment 58423 [details]
Patch

Clearing flags on attachment: 58423

Committed r60989: <http://trac.webkit.org/changeset/60989>
Comment 5 Adam Barth 2010-06-10 22:29:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 WebKit Review Bot 2010-06-10 22:39:16 PDT
http://trac.webkit.org/changeset/60989 might have broken GTK Linux 64-bit Debug and Qt Linux Release
Comment 7 Adam Barth 2010-06-10 22:41:58 PDT
Seems to cause crashes:

dom/html/level2/html/HTMLBodyElement07.html	stderr
dom/html/level2/html/HTMLBodyElement08.html	stderr
dom/html/level2/html/HTMLBodyElement09.html	stderr
dom/html/level2/html/HTMLBodyElement10.html	stderr
dom/html/level2/html/HTMLBodyElement11.html	stderr
dom/html/level2/html/HTMLBodyElement12.html	stderr
dom/html/level2/html/HTMLButtonElement01.html	stderr
dom/html/level2/html/HTMLButtonElement02.html	stderr
dom/html/level2/html/HTMLButtonElement03.html	stderr
dom/html/level2/html/HTMLButtonElement04.html	stderr
dom/html/level2/html/HTMLButtonElement05.html	stderr
dom/html/level2/html/HTMLButtonElement06.html	stderr
dom/html/level2/html/HTMLButtonElement07.html	stderr
dom/html/level2/html/HTMLButtonElement08.html	stderr
dom/html/level2/html/HTMLCollection01.html	stderr
dom/html/level2/html/HTMLCollection02.html	stderr
dom/html/level2/html/HTMLCollection03.html	stderr
dom/html/level2/html/HTMLCollection04.html	stderr
dom/html/level2/html/HTMLCollection05.html	stderr
dom/html/level2/html/HTMLCollection06.html	stderr
Comment 8 Tony Gentilcore 2010-06-11 09:04:04 PDT
Created attachment 58481 [details]
Preserve check for null tokenizer
Comment 9 WebKit Review Bot 2010-06-11 09:05:36 PDT
Attachment 58481 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/dom/Tokenizer.h:28:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 10 Eric Seidel (no email) 2010-06-11 10:28:14 PDT
Comment on attachment 58481 [details]
Preserve check for null tokenizer

LGTM.
Comment 11 WebKit Commit Bot 2010-06-11 11:46:37 PDT
Comment on attachment 58481 [details]
Preserve check for null tokenizer

Clearing flags on attachment: 58481

Committed r61028: <http://trac.webkit.org/changeset/61028>
Comment 12 WebKit Commit Bot 2010-06-11 11:46:44 PDT
All reviewed patches have been landed.  Closing bug.