Bug 40445 - [Qt] Regression(r59956) - Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Summary: [Qt] Regression(r59956) - Return usable property names from DRT's computedSty...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Robert Hogan
URL:
Keywords: Qt, QtTriaged
: 39597 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-06-10 14:26 PDT by Robert Hogan
Modified: 2010-07-03 14:37 PDT (History)
3 users (show)

See Also:

Attachments
Patch (3.76 KB, patch)
2010-06-10 14:31 PDT, Robert Hogan 		kenneth: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Robert Hogan 2010-06-10 14:26:45 PDT 
[Qt] Return usable property names from DRT's computedStyleIncludingVisitedInfo()
Comment 1 Robert Hogan 2010-06-10 14:31:30 PDT 
Created attachment 58413 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-12 18:49:43 PDT 
Comment on attachment 58413 [details]
Patch

Really!?  Do other DRTs need to do this dance too?  Seems sub-optimal if so.
Comment 3 Robert Hogan 2010-06-19 06:19:47 PDT 
(In reply to comment #2)
> (From update of attachment 58413 [details])
> Really!?  Do other DRTs need to do this dance too?  Seems sub-optimal if so.

No, because they can access objects like JSContextRef and JSString directly. The Qt bridge converts JSCore objects to the appropriate Qt counterpart (e.g. QString) and QVariant if all else fails. These QVariant objects are basically large property maps - hence the need to translate the names containing hypens to JS variable-style names.
Comment 4 Kenneth Rohde Christiansen 2010-07-03 07:43:15 PDT 
Comment on attachment 58413 [details]
Patch

Maybe our bridge should be doing this.
Comment 5 Antonio Gomes 2010-07-03 09:39:28 PDT 
*** Bug 39597 has been marked as a duplicate of this bug. ***
Comment 6 Robert Hogan 2010-07-03 14:37:15 PDT 
Committed r62450: <http://trac.webkit.org/changeset/62450>