Bug 40428 - Update acid3 test with latest from acid3.acidtests.org
Summary: Update acid3 test with latest from acid3.acidtests.org
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency tree / graph
 
Reported: 2010-06-10 10:20 PDT by Tony Gentilcore
Modified: 2010-06-11 09:49 PDT (History)
2 users (show)

See Also:

Attachments
Patch (106.31 KB, patch)
2010-06-10 10:25 PDT, Tony Gentilcore 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-06-10 10:20:08 PDT 
Update acid3 test with latest from acid3.acidtests.org
Comment 1 Tony Gentilcore 2010-06-10 10:25:52 PDT 
Created attachment 58383 [details]
Patch
Comment 2 Tony Gentilcore 2010-06-10 10:27:08 PDT 
Incidentally this updated version passes with --html5-parser set, however the expectations were generated without it.
Comment 3 Adam Barth 2010-06-10 10:38:16 PDT 
Comment on attachment 58383 [details]
Patch

Thanks!

LayoutTests/http/tests/misc/acid3.html:2477
 +          assertEquals(doc.firstChild.name.toUpperCase(), "HTML", "name wrong (first test)"); // changed 2009-08-13 to add .toUpperCase() for HTML5 compat
Ah, this is probably the change we needed.
Comment 4 WebKit Commit Bot 2010-06-11 02:10:29 PDT 
Comment on attachment 58383 [details]
Patch

Clearing flags on attachment: 58383

Committed r60999: <http://trac.webkit.org/changeset/60999>
Comment 5 WebKit Commit Bot 2010-06-11 02:10:34 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 6 Alexey Proskuryakov 2010-06-11 09:40:53 PDT 
Why are we failing the linktest? Comments in test code seem to indicate that it's supposed to work with :visited privacy changes now.
Comment 7 Tony Gentilcore 2010-06-11 09:49:03 PDT 
(In reply to comment #6)
> Why are we failing the linktest? Comments in test code seem to indicate that it's supposed to work with :visited privacy changes now.

Not sure. The goal of this patch was just to update to the latest version of the test. The ChangeLog mentions that the same error persists through this patch, it is only the display of the error message that changed. Probably a good idea to open a separate bug for the failure if there isn't one already.