Bug 40412 - [Qt] Explicit conversions to JSC opaque types should be removed.
Summary: [Qt] Explicit conversions to JSC opaque types should be removed.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31863 40415
  Show dependency treegraph
Reported: 2010-06-10 03:00 PDT by Jędrzej Nowacki
Modified: 2010-06-11 03:36 PDT (History)
3 users (show)

See Also:

Fix v1 (21.36 KB, patch)
2010-06-10 03:06 PDT, Jędrzej Nowacki
hausmann: review+
hausmann: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-06-10 03:00:50 PDT
Conversion between JSC C types and QtScript private types, takes a main part of the source code. In most cases a mapping between the types is one to one. New cast operators should be introduced.
Comment 1 Jędrzej Nowacki 2010-06-10 03:06:27 PDT
Created attachment 58351 [details]
Fix v1

No new functionality, refactoring only.
Comment 2 Simon Hausmann 2010-06-11 03:28:46 PDT
Comment on attachment 58351 [details]
Fix v1


but the ChangeLog needs a little cleanup before landing. Right now it just starts with "Explicit conversions to JSC types were removed", which in the
context of JavaScriptCore/ChangeLog does not make much sense.

I'll change this when landing it. Perhaps we should use JavaScriptCore/qt/ChangeLog in the future.
Comment 3 Simon Hausmann 2010-06-11 03:36:44 PDT
Committed r61003: <http://trac.webkit.org/changeset/61003>