Bug 40406 - Move HTML5 entity parser to its own file
Summary: Move HTML5 entity parser to its own file
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency treegraph
 
Reported: 2010-06-10 00:43 PDT by Adam Barth
Modified: 2010-06-10 00:49 PDT (History)
2 users (show)

See Also:


Attachments
Patch (150.87 KB, patch)
2010-06-10 00:45 PDT, Adam Barth
eric: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-10 00:43:33 PDT
Move HTML5 entity parser to its own file
Comment 1 Adam Barth 2010-06-10 00:45:35 PDT
Created attachment 58341 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-10 00:47:53 PDT
Comment on attachment 58341 [details]
Patch

rs=me.
Comment 3 WebKit Review Bot 2010-06-10 00:47:58 PDT
Attachment 58341 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/HTML5EntityParser.cpp:69:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Adam Barth 2010-06-10 00:49:07 PDT
Committed r60941: <http://trac.webkit.org/changeset/60941>