WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
40406
Move HTML5 entity parser to its own file
https://bugs.webkit.org/show_bug.cgi?id=40406
Summary
Move HTML5 entity parser to its own file
Adam Barth
Reported
2010-06-10 00:43:33 PDT
Move HTML5 entity parser to its own file
Attachments
Patch
(150.87 KB, patch)
2010-06-10 00:45 PDT
,
Adam Barth
eric
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-06-10 00:45:35 PDT
Created
attachment 58341
[details]
Patch
Eric Seidel (no email)
Comment 2
2010-06-10 00:47:53 PDT
Comment on
attachment 58341
[details]
Patch rs=me.
WebKit Review Bot
Comment 3
2010-06-10 00:47:58 PDT
Attachment 58341
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/html/HTML5EntityParser.cpp:69: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 11 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 4
2010-06-10 00:49:07 PDT
Committed
r60941
: <
http://trac.webkit.org/changeset/60941
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug