Bug 40385 - Fix fast/parser/hex-entities-length.html for HTML5 parser
Summary: Fix fast/parser/hex-entities-length.html for HTML5 parser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Gentilcore
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency treegraph
 
Reported: 2010-06-09 12:46 PDT by Tony Gentilcore
Modified: 2010-06-09 15:05 PDT (History)
2 users (show)

See Also:


Attachments
Patch (2.00 KB, patch)
2010-06-09 12:56 PDT, Tony Gentilcore
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Gentilcore 2010-06-09 12:46:02 PDT
Fix fast/parser/hex-entities-length.html for HTML5 parser
Comment 1 Tony Gentilcore 2010-06-09 12:56:02 PDT
Created attachment 58281 [details]
Patch
Comment 2 Tony Gentilcore 2010-06-09 13:07:55 PDT
Minefield passes this test, and it appears that if the "Preprocessing the input stream" spec were strictly followed it could not pass the test.

Also, I poked around at the minefield implementation and found where these character ranges are replaced for entities (in handleNcrValue). But can't find anywhere where they are replaced in the input stream itself (they are just passed to emitOrAppendTwo). Links:
http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5Tokenizer.cpp
http://mxr.mozilla.org/mozilla-central/source/parser/html/nsHtml5StreamParser.cpp
Comment 3 Adam Barth 2010-06-09 14:54:49 PDT
Comment on attachment 58281 [details]
Patch

Yep.  This will fix a bunch of tests, actually.

Can you email public-html with this feedback on the spec?
Comment 4 Adam Barth 2010-06-09 15:05:33 PDT
Comment on attachment 58281 [details]
Patch

Clearing flags on attachment: 58281

Committed r60916: <http://trac.webkit.org/changeset/60916>
Comment 5 Adam Barth 2010-06-09 15:05:40 PDT
All reviewed patches have been landed.  Closing bug.