Bug 40284 - Implement HTML5's forceQuirks flag
Summary: Implement HTML5's forceQuirks flag
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks: 39259
  Show dependency treegraph
 
Reported: 2010-06-07 23:53 PDT by Adam Barth
Modified: 2010-06-08 00:16 PDT (History)
1 user (show)

See Also:


Attachments
Patch (9.56 KB, patch)
2010-06-07 23:55 PDT, Adam Barth
no flags Details | Formatted Diff | Diff
Patch for landing (9.94 KB, patch)
2010-06-08 00:04 PDT, Adam Barth
abarth: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-06-07 23:53:32 PDT
Implement HTML5's forceQuirks flag
Comment 1 Adam Barth 2010-06-07 23:55:34 PDT
Created attachment 58115 [details]
Patch
Comment 2 Eric Seidel (no email) 2010-06-08 00:00:07 PDT
Comment on attachment 58115 [details]
Patch

WebCore/html/HTMLParser.cpp:349
 +      if (t->m_forceQuirks)
We should add some comment(s) here about how the two parsers work.  You should reference the FIXME inside Document::addChild and how the legacy parser had intended to move the logic out here.

How's our test coverage here?  Do we feel it's sufficient?
Comment 3 Adam Barth 2010-06-08 00:04:14 PDT
Created attachment 58120 [details]
Patch for landing
Comment 4 Adam Barth 2010-06-08 00:16:05 PDT
Committed r60826: <http://trac.webkit.org/changeset/60826>