Bug 40120 - [Qt] QScriptValue should have an instanceOf method
Summary: [Qt] QScriptValue should have an instanceOf method
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jędrzej Nowacki
URL:
Keywords: Qt, QtTriaged
Depends on:
Blocks: 31863
  Show dependency treegraph
 
Reported: 2010-06-03 07:04 PDT by Jędrzej Nowacki
Modified: 2010-06-04 17:23 PDT (History)
3 users (show)

See Also:


Attachments
Fix v1 (7.93 KB, patch)
2010-06-03 07:13 PDT, Jędrzej Nowacki
kenneth: review+
Details | Formatted Diff | Diff
Fix v1.01 (7.97 KB, patch)
2010-06-04 03:28 PDT, Jędrzej Nowacki
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jędrzej Nowacki 2010-06-03 07:04:54 PDT
The QScriptValue should have an instancOf method, something like:
http://doc.trolltech.com/4.6/qscriptvalue.html#instanceOf
Comment 1 Jędrzej Nowacki 2010-06-03 07:13:55 PDT
Created attachment 57764 [details]
Fix v1
Comment 2 Kenneth Rohde Christiansen 2010-06-03 09:40:52 PDT
Comment on attachment 57764 [details]
Fix v1

JavaScriptCore/qt/api/qscriptvalue.cpp:590
 +    Returns true if this QScriptValue is an instance of
Is the indentation correct here? It is supposed to be 4.
Comment 3 Jędrzej Nowacki 2010-06-04 03:28:53 PDT
Created attachment 57860 [details]
Fix v1.01

(In reply to comment #2)
> (From update of attachment 57764 [details])
> JavaScriptCore/qt/api/qscriptvalue.cpp:590
>  +    Returns true if this QScriptValue is an instance of
> Is the indentation correct here? It is supposed to be 4.
Fixed.
Comment 4 WebKit Commit Bot 2010-06-04 17:23:23 PDT
Comment on attachment 57860 [details]
Fix v1.01

Clearing flags on attachment: 57860

Committed r60725: <http://trac.webkit.org/changeset/60725>
Comment 5 WebKit Commit Bot 2010-06-04 17:23:28 PDT
All reviewed patches have been landed.  Closing bug.